[ 
https://issues.apache.org/jira/browse/PIG-2663?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13264221#comment-13264221
 ] 

Bill Graham commented on PIG-2663:
----------------------------------

That seems reasonable. So we'd also then move AliasVisitor and FeatureVisitor 
to MapReduceOper too.

What about the local cache of MapReduceOper to Aliases and Features that 
ScriptState holds on to? That would need to stay in ScriptState since that 
class has the entire plan in scope. Calling those methods would be more 
efficient then repeatedly calling MapReduceOper.getAlias() since you don't need 
to re-walk each time. Maybe that's ok.

Ideally MapReduceOper could lazy load a reference to it's alias and feature 
when its methods are first called, but that class isn't immutable so I don't 
think that would fly.
                
> Expose helpful ScriptState methods
> ----------------------------------
>
>                 Key: PIG-2663
>                 URL: https://issues.apache.org/jira/browse/PIG-2663
>             Project: Pig
>          Issue Type: Improvement
>            Reporter: Bill Graham
>            Assignee: Bill Graham
>         Attachments: PIG-2663.1.patch
>
>
> The {{ScriptState.getAlias(MapReduceOper mro)}} and 
> {{ScriptState.getFeature(MapReduceOper mro)}} methods are useful in 
> implementations of {{PigProgressNotificationListener}}. I'd like to make them 
> public.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to