[ 
https://issues.apache.org/jira/browse/PIG-2657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13266613#comment-13266613
 ] 

Gianmarco De Francisci Morales commented on PIG-2657:
-----------------------------------------------------

Hi,
thanks for sending a patch.
I have one concern, on which I would like advice from the community.
Hardcoding version numbers in the source is not maintainable in the long run in 
my opinion (we will forget about this when we upgrade jython).
Is there a way to programmatically and portably get the version number?
It would be easy to read the ivy/library.properties file and get the 
jython.version property, however this file is not bundled with pig.jar.
My suggestion would be to put this information in the MANIFEST.MF, which is 
created by ant.
This way it is easily recoverable from within the jar and it is easy to put 
there because the version number is available during the build process.

Thoughts?
                
> Print warning if using wrong jython version
> -------------------------------------------
>
>                 Key: PIG-2657
>                 URL: https://issues.apache.org/jira/browse/PIG-2657
>             Project: Pig
>          Issue Type: Bug
>            Reporter: Fabian Alenius
>         Attachments: PIG-2657.1.patch
>
>
> Hi,
> It would be good if Pig would print a warning (or refuse to run) if you are 
> using an unsupported version of jython. I spent a couple of hours before 
> figuring out that you had to use 2.5.0. I've seen posts indicating that 
> others have run into this problem as well.
> Might write up a patch if others agree this is an issue.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to