Travis Crawford created PIG-2730:
------------------------------------

             Summary: TFileStorage getStatistics incorrectly throws an 
exception instead of returning null
                 Key: PIG-2730
                 URL: https://issues.apache.org/jira/browse/PIG-2730
             Project: Pig
          Issue Type: Bug
            Reporter: Travis Crawford
            Assignee: Travis Crawford


[TFileStorage.java|http://svn.apache.org/repos/asf/pig/trunk/src/org/apache/pig/impl/io/TFileStorage.java]
 throws an exception in getStatistics:

{code}
@Override
public ResourceStatistics getStatistics(String location, Job job) throws 
IOException {
  throw new UnsupportedOperationException();
}
{code}

However the interface for 
[LoadMetadata.java|http://svn.apache.org/repos/asf/pig/trunk/src/org/apache/pig/LoadMetadata.java]
 states null should be returned if statistics are not available:

{code}
/**
 * Get statistics about the data to be loaded.  If no statistics are
 * available, then null should be returned. If the implementing class also 
extends
 * {@link LoadFunc}, then {@link LoadFunc#setLocation(String, 
org.apache.hadoop.mapreduce.Job)}
 * is guaranteed to be called before this method.
 * @param location Location as returned by 
 * {@link LoadFunc#relativeToAbsolutePath(String, org.apache.hadoop.fs.Path)}
 * @param job The {@link Job} object - this should be used only to obtain 
 * cluster properties through {@link Job#getConfiguration()} and not to 
set/query
 * any runtime job information.  
 * @return statistics about the data to be loaded.  If no statistics are
 * available, then null should be returned.
 * @throws IOException if an exception occurs while retrieving statistics
 */
ResourceStatistics getStatistics(String location, Job job) 
throws IOException;
{code}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to