[
https://issues.apache.org/jira/browse/PIG-2724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13286177#comment-13286177
]
Julien Le Dem commented on PIG-2724:
------------------------------------
Thanks Jonathan.
Overall, this looks good.
Some extra comments:
* In javadoc you can use the following tag whenever you want to reuse the same
doc as in the implemented method (for example isNull(int))
{code}
/**
* {@inheritDoc}
*/
{code}
* I would not necessarily create AbstractTypeAwareTuple unless there is
something to add in it
* It looks like the toDelimitedString() in DefaultTuple was doing something
different (nnull would be written differently) than the new default one in
AbstractTuple. We may want to make sure we keep the same behavior in case
someone is parsing it. You could add a test for this.
* hashCode() could be in AbstractTuple as well as it just needs an object
iterator (that you just provided!)
> Make Tuple Iterable
> -------------------
>
> Key: PIG-2724
> URL: https://issues.apache.org/jira/browse/PIG-2724
> Project: Pig
> Issue Type: Improvement
> Reporter: Jonathan Coveney
> Assignee: Jonathan Coveney
> Fix For: 0.11
>
> Attachments: PIG-2724-0.patch, PIG-2724-1.patch, PIG-2724-1.patch
>
>
> Seriously, is there a more annoying pattern than the following?
> {code}
> for (int i = 0; i < t.size(); i++) {
> try {
> doStuff(t.get(i));
> } catch (ExecException e) {
> throw new RuntimeException("BUT I THOUGHT PIG WAS SINGLETHREADED", e);
> }
> }
> {code}
> I mean yeah, you can do the following:
> {code}
> for (Object o : t.getAll()) {
> doStuff(o);
> }
> {code}
> But I don't even think that should be necessary. I think the following should
> work:
> {code}
> for (Object o : t) {
> doStuff(o);
> }
> {code}
> It's a shame we can't give a default implementation (I either shake my fist
> that this won't be possible until Java 8 OR that Tuple is an interface and
> not an abstract class). Either way, I even added test! WOAH.
> Thoughts?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
