----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5591/#review8819 -----------------------------------------------------------
This is a great patch! Here are some comments. /trunk/src/org/apache/pig/scripting/groovy/AccumulatorAccumulate.java <https://reviews.apache.org/r/5591/#comment18680> javadoc please for these /trunk/src/org/apache/pig/scripting/groovy/GroovyAlgebraicEvalFunc.java <https://reviews.apache.org/r/5591/#comment18683> it does not do anything more than calling the parent then it does not realy need to override the method. (same for other classes here) /trunk/src/org/apache/pig/scripting/groovy/GroovyAlgebraicEvalFunc.java <https://reviews.apache.org/r/5591/#comment18685> this is actually a funcspec and could return "org.apache....Final('Double')" if that helps. /trunk/test/org/apache/pig/test/TestUDFGroovy.java <https://reviews.apache.org/r/5591/#comment18686> What about this syntax? class Sumalg extends AgebraicGroovyUDF {", public Tuple initial(Tuple t) { ... } public Tuple intermed(Tuple t) { ... } public long final(Tuple t) { ... } } This would be consistent with the JRuby impl (and java in general) - Julien Le Dem On July 2, 2012, 9:23 p.m., Mathias Herberts wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/5591/ > ----------------------------------------------------------- > > (Updated July 2, 2012, 9:23 p.m.) > > > Review request for pig, Julien Le Dem and Jonathan Coveney. > > > Description > ------- > > Adds support for Groovy UDFs in Pig. > > > This addresses bug PIG-2763. > https://issues.apache.org/jira/browse/PIG-2763 > > > Diffs > ----- > > /trunk/ivy.xml 1353307 > /trunk/ivy/libraries.properties 1353307 > /trunk/src/org/apache/pig/scripting/ScriptEngine.java 1356486 > /trunk/src/org/apache/pig/scripting/groovy/AccumulatorAccumulate.java > PRE-CREATION > /trunk/src/org/apache/pig/scripting/groovy/AccumulatorCleanup.java > PRE-CREATION > /trunk/src/org/apache/pig/scripting/groovy/AccumulatorGetValue.java > PRE-CREATION > /trunk/src/org/apache/pig/scripting/groovy/AlgebraicFinal.java PRE-CREATION > /trunk/src/org/apache/pig/scripting/groovy/AlgebraicInitial.java > PRE-CREATION > /trunk/src/org/apache/pig/scripting/groovy/AlgebraicIntermed.java > PRE-CREATION > /trunk/src/org/apache/pig/scripting/groovy/GroovyAccumulatorEvalFunc.java > PRE-CREATION > /trunk/src/org/apache/pig/scripting/groovy/GroovyAlgebraicEvalFunc.java > PRE-CREATION > /trunk/src/org/apache/pig/scripting/groovy/GroovyEvalFunc.java PRE-CREATION > /trunk/src/org/apache/pig/scripting/groovy/GroovyEvalFuncObject.java > PRE-CREATION > /trunk/src/org/apache/pig/scripting/groovy/GroovyScriptEngine.java > PRE-CREATION > /trunk/src/org/apache/pig/scripting/groovy/GroovyUtils.java PRE-CREATION > /trunk/src/org/apache/pig/scripting/groovy/OutputSchemaFunction.java > PRE-CREATION > /trunk/test/org/apache/pig/test/TestUDFGroovy.java PRE-CREATION > /trunk/test/unit-tests 1353307 > > Diff: https://reviews.apache.org/r/5591/diff/ > > > Testing > ------- > > > Thanks, > > Mathias Herberts > >
