> On July 2, 2012, 1:49 a.m., Dmitriy Ryaboy wrote: > > http://svn.apache.org/repos/asf/pig/trunk/src/org/apache/pig/builtin/CubeDimensions.java, > > line 94 > > <https://reviews.apache.org/r/5470/diff/1/?file=115075#file115075line94> > > > > I would rather we set the fields, rather than copy the tuple and then > > set them. Unnecessary copies => time + gc pressure.
Updated this in second patch of PIG-2765 JIRA (PIG-2765.2.patch). PIG-2765 patch is generated on top of PIG-2726 patch. I assume that PIG-2726 will be committed first followed by PIG-2765. After committing the patch for PIG-2726, do I need to regenerate the patch for PIG-2765 against the trunk? - Prasanth_J ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5470/#review8777 ----------------------------------------------------------- On June 21, 2012, 5:44 a.m., Prasanth_J wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/5470/ > ----------------------------------------------------------- > > (Updated June 21, 2012, 5:44 a.m.) > > > Review request for pig and Dmitriy Ryaboy. > > > Description > ------- > > This is a review board for https://issues.apache.org/jira/browse/PIG-2726 > > > This addresses bug PIG-2726. > https://issues.apache.org/jira/browse/PIG-2726 > > > Diffs > ----- > > > http://svn.apache.org/repos/asf/pig/trunk/src/org/apache/pig/builtin/CubeDimensions.java > 1350081 > > http://svn.apache.org/repos/asf/pig/trunk/src/org/apache/pig/parser/LogicalPlanBuilder.java > 1350081 > > http://svn.apache.org/repos/asf/pig/trunk/test/org/apache/pig/test/TestCubeOperator.java > 1350081 > > Diff: https://reviews.apache.org/r/5470/diff/ > > > Testing > ------- > > Unit tests: All passed > > Pre-commit tests: All passed > ant clean test-commit > > > Thanks, > > Prasanth_J > >
