[ 
https://issues.apache.org/jira/browse/PIG-2706?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13416079#comment-13416079
 ] 

Gianmarco De Francisci Morales commented on PIG-2706:
-----------------------------------------------------

Patch looks good.
A couple of minor things:

We use spaces not tabs, can you regenerate the patch with proper formatting?
https://cwiki.apache.org/confluence/display/PIG/HowToContribute#HowToContribute-MakingChanges

Do we need to separate the cases Windows/non-Windows in GruntParser.java? Isn't 
Jansi cross platform?

I tested it manually and it works fine. I guess it is very hard to test it 
automatically so we can do without tests.
                
> Add clear to list of grunt commands
> -----------------------------------
>
>                 Key: PIG-2706
>                 URL: https://issues.apache.org/jira/browse/PIG-2706
>             Project: Pig
>          Issue Type: Improvement
>          Components: grunt
>    Affects Versions: 0.11, 0.10.1
>            Reporter: Prashant Kommireddi
>            Assignee: Allan AvendaƱo
>         Attachments: PIG-2706, PIG-2706-2, PIG-2706-3, PIG-2706-4
>
>
> grunt should be able to clear screen (similar to unix shell) on a command, we 
> can call it "clear". After typing in several lines in the interactive mode, 
> it would be useful to be able to clear screen.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira


Reply via email to