[ 
https://issues.apache.org/jira/browse/PIG-2873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13439258#comment-13439258
 ] 

Alan Gates commented on PIG-2873:
---------------------------------

Comments:

1)
{code}
try:
  confFileHdl = open(os.path.join(os.environ['PIG_CONF_DIR'], 'pig.conf'), 'r')
  for line in confFileHdl:
    words = line.split()
    if len(words) > 2: # since we expect only key value pairs
      continue
    else:
      os.eviron[words[0]] = words[1]
{code}
Won't the test "len(words) > 2" mean we reject lines with comments?  E.g. 
"key=value # this is a comment"

2) In the HCat section we should look for hive jar in /usr/lib/hive when 
HIVE_HOME isn't set, since that's where Bigtop RPMs put them?  Same for 
HCAT_HOME.
                
> Converting bin/pig shell script to python
> -----------------------------------------
>
>                 Key: PIG-2873
>                 URL: https://issues.apache.org/jira/browse/PIG-2873
>             Project: Pig
>          Issue Type: Bug
>          Components: tools
>    Affects Versions: 0.10.0
>            Reporter: Vikram Dixit K
>            Assignee: Vikram Dixit K
>            Priority: Minor
>         Attachments: PIG-2873_2.patch, PIG-2873.patch
>
>
> Converted the shell script in a platform independent way in python. Should 
> work with version 2.7.x

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to