[
https://issues.apache.org/jira/browse/PIG-2886?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13439273#comment-13439273
]
Bill Graham commented on PIG-2886:
----------------------------------
Thanks for the patch Ted! The code looks good, just a few nits about style
mainly.
- That patch has a bunch of diff info about your git internal files, so it
doesn't apply.
- Standard indents in Pig are 4 spaces (no tabs).
- Use a single space after brackets and between close parens and open brackets
in your else/if statements.
- else should be on one line, i.e., } else {
- A pair of empty newlines were added after the {{ignoreWhitespace_}} block,
which should be removed.
- Typos: TimeRagne and "Timestamp most be"
Also would you please add a unit test to TestHBaseStorage.
> Add Scan TimeRange to HBaseStorage
> -----------------------------------
>
> Key: PIG-2886
> URL: https://issues.apache.org/jira/browse/PIG-2886
> Project: Pig
> Issue Type: Bug
> Reporter: Ted Malaska
> Priority: Minor
> Attachments: PIG-2886-0.patch
>
>
> I have a client that wants to use pig. They are using MR now. They can't
> use PIG right now because they only want to fetch the last day's worth of
> data in HBase. A filter with time range would require reading all the HStore
> files. If we hold major compaction until after the fetch and use Scan Time
> Range we only need to read very little in compression.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
