----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7053/#review12079 -----------------------------------------------------------
Just few minor comments. I ran the patch on branch-0.10 after reverting the commented out test in steaming_local.conf. It passed fine in Hadoop 1.0.2 but hung in hadoop 0.23. With the previous patch changing to -Dmapreduce.cluster.local.dir it was passing in Hadoop 0.23. I am trying to debug that. http://svn.apache.org/repos/asf/pig/trunk/test/e2e/harness/test_harness.pl <https://reviews.apache.org/r/7053/#comment25774> Can't we do this by getting $ENV{'HADOOP_MAPRED_LOCAL_DIR'} in local.conf? Or is there some reason for doing it this way? http://svn.apache.org/repos/asf/pig/trunk/test/e2e/harness/TestDriver.pm <https://reviews.apache.org/r/7053/#comment25777> Any reason for this length based formatting? In fact it makes the string even more longer than before. Just curious to know why this is being done. http://svn.apache.org/repos/asf/pig/trunk/test/e2e/pig/build.xml <https://reviews.apache.org/r/7053/#comment25741> Default /tmp/hadoop/mapred/local/? http://svn.apache.org/repos/asf/pig/trunk/test/e2e/pig/conf/local.conf <https://reviews.apache.org/r/7053/#comment25740> Same as prev 2 comments. Just repeating it in context. Can this be ENV{HADOOP_MAPRED_LOCAL_DIR} and define /tmp/hadoop/mapred/local as the default in build.xml similar to other variables in this conf? http://svn.apache.org/repos/asf/pig/trunk/test/e2e/pig/drivers/TestDriverPig.pm <https://reviews.apache.org/r/7053/#comment25793> 1024m instead of 1025m http://svn.apache.org/repos/asf/pig/trunk/test/e2e/pig/drivers/TestDriverPig.pm <https://reviews.apache.org/r/7053/#comment25739> Nice to see someone fix this one. Has always bothered my eyes while looking at the logs too see it appended so many times :). Can we remove the code altogether instead of commenting out. http://svn.apache.org/repos/asf/pig/trunk/test/e2e/pig/tests/streaming_local.conf <https://reviews.apache.org/r/7053/#comment25738> Instead of commenting this out in this patch, we can create a new jira so that this test can be fixed. TestStreaming unit tests also are timing out in trunk. So there might be a bug with streaming that needs to be fixed before 0.11 is released. The test runs fine in 0.10 in seq mode. Removing this will also make the patch apply cleanly on 0.10 else we need to create a patch for 0.10. - Rohini Palaniswamy On Sept. 28, 2012, 12:20 p.m., Ivan Veselovsky wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/7053/ > ----------------------------------------------------------- > > (Updated Sept. 28, 2012, 12:20 p.m.) > > > Review request for pig and Rohini Palaniswamy. > > > Description > ------- > > Please see https://issues.apache.org/jira/browse/PIG-2898 for details. > > > This addresses bug https://issues.apache.org/jira/browse/PIG-2898. > > https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/PIG-2898 > > > Diffs > ----- > > http://svn.apache.org/repos/asf/pig/trunk/test/e2e/harness/TestDriver.pm > 1390615 > http://svn.apache.org/repos/asf/pig/trunk/test/e2e/harness/test_harness.pl > 1390615 > http://svn.apache.org/repos/asf/pig/trunk/test/e2e/pig/build.xml 1390615 > http://svn.apache.org/repos/asf/pig/trunk/test/e2e/pig/conf/local.conf > 1390615 > > http://svn.apache.org/repos/asf/pig/trunk/test/e2e/pig/deployers/ExistingClusterDeployer.pm > 1390615 > > http://svn.apache.org/repos/asf/pig/trunk/test/e2e/pig/drivers/TestDriverPig.pm > 1390615 > > http://svn.apache.org/repos/asf/pig/trunk/test/e2e/pig/tests/streaming_local.conf > 1390615 > > Diff: https://reviews.apache.org/r/7053/diff/ > > > Testing > ------- > > Tested e2e tests execution in both sequential (default) and parallel modes. > The test run duration measurement data (in dependency on the fork parameters) > will be available soon. > > > Thanks, > > Ivan Veselovsky > >
