[
https://issues.apache.org/jira/browse/PIG-2975?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Koji Noguchi updated PIG-2975:
------------------------------
Attachment:
pig-2975-trunk_v05-BinInterSedesRawComparatorAndlightweight-withtest.txt
Attaching patch with Jonathan's suggested changes (except the first one).
Thanks Jonathan for all your help and being patient with me!
bq. l1 is a really hard to read. Please use fuller names (even len1 and len2)
Agree. But this is coming from the original code. l1,s1,l2,s2 seem to be used
everywhere for compare() method unfortunately. Leaving them for now.
bq. IMHO, spaces make = and + etc more readable (ie databytearraycompare=false)
Added.
bq. on that front, use camelCase for multi-word lines
Changed.
Also added couple of test cases for incorrect results and one for Alphabetical
sorting of bytearrays across Tiny/Small/Regular size boundaries.
> TestTypedMap.testOrderBy failing with incorrect result
> -------------------------------------------------------
>
> Key: PIG-2975
> URL: https://issues.apache.org/jira/browse/PIG-2975
> Project: Pig
> Issue Type: Sub-task
> Affects Versions: 0.11
> Reporter: Koji Noguchi
> Assignee: Koji Noguchi
> Priority: Blocker
> Fix For: 0.11
>
> Attachments: PIG-2975-0_jco.patch, PIG-2975-0_jco-v2.patch,
> pig-2975-trunk_v01.txt, pig-2975-trunk_v02-broken.txt,
> pig-2975-trunk_v03-unionapproach.txt, pig-2975-trunk_v04-purerawcompare.txt,
> pig-2975-trunk_v05-BinInterSedesRawComparatorAndlightweight-withouttest.txt,
> pig-2975-trunk_v05-BinInterSedesRawComparatorAndlightweight-withtest.txt
>
>
> Looked at
> {noformat}
> junit.framework.AssertionFailedError
> at org.apache.pig.test.TestTypedMap.testOrderBy(TestTypedMap.java:352)
> {noformat}
> This looks like a valid test case failing with incorrect result.
> {noformat}
> % cat test/orderby.txt
> [key#1,key9#23]
> [key#3,key3#2]
> [key#22]
> % cat test/orderby.pig
> a = load 'test/orderby.txt' as (m:[]);
> b = foreach a generate m#'key' as b0;
> dump b;
> c = order b by b0;
> dump c;
> % java ... org.apache.pig.Main -x local test/orderby.pig
> [dump b]
> (1)
> (3)
> (22)
> ...
> [dump c]
> (1)
> (1)
> (22)
> %
> where did the '(3)' go?
> {noformat}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
