[ 
https://issues.apache.org/jira/browse/PIG-2999?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13482096#comment-13482096
 ] 

Rohini Palaniswamy commented on PIG-2999:
-----------------------------------------

+1 (non-binding) for the patch. I am also seeing failures.For eg. 
TestPigTupleRawComparator tests fail with OOM.  Had mentioned about the 
bb.position having to be incremented earlier to Koji, then retracted the 
statement when I looked at the code and thought the ByteBuffer was not accessed 
after that. But I was mistaken and it is accessed again in case of secondary 
sort.

{code}
result = compareBinInterSedesDatum(bb1, bb2, mAsc);
                        if (result == 0)
                            result = compareBinInterSedesDatum(bb1, bb2, 
mSecondaryAsc);
{code} 
                
> Regression after PIG-2975: BinInterSedesTupleRawComparator secondary sort 
> failing
> ---------------------------------------------------------------------------------
>
>                 Key: PIG-2999
>                 URL: https://issues.apache.org/jira/browse/PIG-2999
>             Project: Pig
>          Issue Type: Bug
>    Affects Versions: 0.11, 0.12
>            Reporter: Koji Noguchi
>            Assignee: Jonathan Coveney
>         Attachments: pig-2999-v1.txt
>
>
> I think I broke the build from PIG-2975.  I see couple of tests failing at 
> BinInterSedesTupleRawComparator. 
> {noformat}
> 12/10/22 22:26:15 WARN mapred.LocalJobRunner: job_local_0022
> java.nio.BufferUnderflowException
>       at java.nio.Buffer.nextGetIndex(Buffer.java:478)
>       at java.nio.HeapByteBuffer.getLong(HeapByteBuffer.java:387)
>       at 
> org.apache.pig.data.BinInterSedes$BinInterSedesTupleRawComparator.compareBinInterSedesDatum(BinInterSedes.java:829)
>       at 
> org.apache.pig.data.BinInterSedes$BinInterSedesTupleRawComparator.compareBinSedesTuple(BinInterSedes.java:732)
>       at 
> org.apache.pig.data.BinInterSedes$BinInterSedesTupleRawComparator.compare(BinInterSedes.java:695)
>       at 
> org.apache.pig.backend.hadoop.executionengine.mapReduceLayer.PigSecondaryKeyComparator.compare(PigSecondaryKeyComparator.java:78)
>       at org.apache.hadoop.mapred.Merger$MergeQueue.lessThan(Merger.java:373)
>       at org.apache.hadoop.util.PriorityQueue.downHeap(PriorityQueue.java:139)
>       at 
> org.apache.hadoop.util.PriorityQueue.adjustTop(PriorityQueue.java:103)
>       at 
> org.apache.hadoop.mapred.Merger$MergeQueue.adjustPriorityQueue(Merger.java:335)
>       at org.apache.hadoop.mapred.Merger$MergeQueue.next(Merger.java:350)
>       at org.apache.hadoop.mapred.ReduceTask$4.next(ReduceTask.java:625)
>       at 
> org.apache.hadoop.mapreduce.ReduceContext.nextKeyValue(ReduceContext.java:117)
>       at 
> org.apache.hadoop.mapreduce.ReduceContext.nextKey(ReduceContext.java:92)
>       at org.apache.hadoop.mapreduce.Reducer.run(Reducer.java:175)
>       at 
> org.apache.hadoop.mapred.ReduceTask.runNewReducer(ReduceTask.java:649)
>       at org.apache.hadoop.mapred.ReduceTask.run(ReduceTask.java:417)
>       at 
> org.apache.hadoop.mapred.LocalJobRunner$Job.run(LocalJobRunner.java:260)
> {noformat}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to