[
https://issues.apache.org/jira/browse/PIG-3001?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13483856#comment-13483856
]
Jonathan Coveney commented on PIG-3001:
---------------------------------------
No worries on the whitespace. Like I said: I wish it weren't so, but the worry
is breaking old or in-transit patches.
IMHO, I would prefer for it to simply fail out, since this on the front end.
That said, I don't think that is currently an option since it would break a lot
of scripts. I propose the following:
- In the case where there is a conversion, we should throw a warning
- There can be a flag which sets whether or not we should instead error out.
It'll default turned to no, but then people can set it in their confs.
I do not like things that automagically do things, though in some cases it
could be inavoidable
> TestExecutableManager.testAddJobConfToEnv fails randomly
> --------------------------------------------------------
>
> Key: PIG-3001
> URL: https://issues.apache.org/jira/browse/PIG-3001
> Project: Pig
> Issue Type: Sub-task
> Reporter: Gianmarco De Francisci Morales
> Assignee: Cheolsoo Park
> Priority: Minor
> Attachments: PIG-3001-2.patch, PIG-3001-3.patch, PIG-3001.patch
>
>
> The test in the Summary fails intermittently.
> This is due to using a random number generator without seeding it.
> We should avoid stochastic tests.
> Furthermore, the test itself is ill conceived.
> Here the failure summary:
> {code}
> 12/10/23 11:02:48 WARN streaming.ExecutableManager: Property set in
> pig.streaming.environment not found in Configuration: ⻨ꢏ切歯
> 12/10/23 11:02:48 WARN streaming.ExecutableManager: Property set in
> pig.streaming.environment not found in Configuration: 狓偝
> 12/10/23 11:02:48 WARN streaming.ExecutableManager: Property set in
> pig.streaming.environment not found in Configuration: 墣챟㌌̀썬鼹騷
> 12/10/23 11:02:48 WARN streaming.ExecutableManager: Property set in
> pig.streaming.environment not found in Configuration: 훎滼
> {code}
> {code}
> Error Message:
> There should be no remaining pairs in the included map
> Stacktrace:
> junit.framework.AssertionFailedError: There should be no remaining pairs in
> the included map
> at
> org.apache.pig.impl.streaming.TestExecutableManager.testAddJobConfToEnv(TestExecutableManager.java:84)
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira