[
https://issues.apache.org/jira/browse/PIG-3016?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Cheolsoo Park updated PIG-3016:
-------------------------------
Attachment: PIG-3016-1-nowhitespace.patch
PIG-3016-1.patch
Since PIG-3006 is committed now, I re-based the patch to trunk. I am uploading
two patches: w/ and w/o white space changes.
In addition to re-basing it, I made two changes as follows:
- Reverted the following change since it is not correct:
{code:title=TestDataModel.java}
- assertFalse(f1.equals(f2));
+ assertEquals(f1, f2);
{code}
- In several places, changed the following
{code}
if (!iter.hasNext())
fail("No Output received");
{code}
to
{code}
assertTrue("No Output received", iter.hasNext());
{code}
Other than this, I made no further changes to Jonathan's original patch.
I am giving +1 to Jonathan's patch. After running a full unit test suite with
both hadoop 20 and 23 tonight, I am going to commit it to trunk.
Please let me know if you have any concerns.
Thanks!
> Modernize more tests
> --------------------
>
> Key: PIG-3016
> URL: https://issues.apache.org/jira/browse/PIG-3016
> Project: Pig
> Issue Type: Improvement
> Reporter: Jonathan Coveney
> Assignee: Jonathan Coveney
> Fix For: 0.12
>
> Attachments: PIG-3016-0.patch, PIG-3016-1-nowhitespace.patch,
> PIG-3016-1.patch
>
>
> This takes the same idea as PIG-3006 and applies it to the remaining tests.
> Note that the one thing I did not do was get rid of MiniCluster. That can be
> for another JIRA. All of this refactoring is effort enough for the time being
> :)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
