[
https://issues.apache.org/jira/browse/PIG-2657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13495644#comment-13495644
]
Cheolsoo Park commented on PIG-2657:
------------------------------------
Hi Johnny,
Thank you very much for the patch. I have a few more comments:
- I think that you have to swap {{Version.PY_VERSION}} and {{jythonVersion}}.
- Looking at {{JythonScriptEngine.java}} after apply your patch, I see no
reason why we nest try-catch blocks here. Can you please move the inner
try-catch block to outside the outer one? In addition, can you make it to catch
an IOException instead of an Exception since that's specifically what is thrown
by {{JarFile}}? Do you agree?
- Please remove tabs in {{build.xml}}.
> Print warning if using wrong jython version
> -------------------------------------------
>
> Key: PIG-2657
> URL: https://issues.apache.org/jira/browse/PIG-2657
> Project: Pig
> Issue Type: Bug
> Reporter: Fabian Alenius
> Labels: newbie
> Fix For: 0.12
>
> Attachments: PIG-2657.1.patch, PIG-2657.2.patch, PIG-2657.3.patch
>
>
> Hi,
> It would be good if Pig would print a warning (or refuse to run) if you are
> using an unsupported version of jython. I spent a couple of hours before
> figuring out that you had to use 2.5.0. I've seen posts indicating that
> others have run into this problem as well.
> Might write up a patch if others agree this is an issue.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
