[ 
https://issues.apache.org/jira/browse/PIG-3014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13507725#comment-13507725
 ] 

Rohini Palaniswamy commented on PIG-3014:
-----------------------------------------

bq. Since the test case is not valid, I simply removed it.

+1. TestCurrentTime covers CurrentTime udf adequately.

Just an observation though. All builtin udf tests are in TestBuiltin, but 
CurrentTime alone has a separate test class with just one test. Should we move 
that to TestBuiltin?
                
> CurrentTime() UDF has undesirable characteristics
> -------------------------------------------------
>
>                 Key: PIG-3014
>                 URL: https://issues.apache.org/jira/browse/PIG-3014
>             Project: Pig
>          Issue Type: Bug
>            Reporter: Jonathan Coveney
>            Assignee: Jonathan Coveney
>             Fix For: 0.12
>
>         Attachments: PIG-3014-0.patch, PIG-3014-1.patch, PIG-3014-2.patch, 
> PIG-3014-3.patch
>
>
> As part of the explanation of the new DateTime datatype I noticed that we had 
> added a CurrentTime() UDF. The issue with this UDF is that it returns the 
> current time _of every exec invocation_, which can lead to confusing results. 
> In PIG-1431 I proposed a way such that every instance of the same NOW() will 
> return the same time, which I think is better. Would enjoy thoughts.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to