[ 
https://issues.apache.org/jira/browse/PIG-3044?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Cheolsoo Park reopened PIG-3044:
--------------------------------


Hi Dmitriy,

This patch broke trunk and branch-0.11. Several test cases are failing, for 
example, TestDataBag, TestExampleGenerator, TestLogicalPlanBuilder, etc:
{code}
Testcase: testDataBagIterIdempotent took 0.011 sec 
    Caused an ERROR
/ by zero
java.lang.ArithmeticException: / by zero
    at 
org.apache.pig.data.DefaultAbstractBag.getMemorySize(DefaultAbstractBag.java:160)
    at 
org.apache.pig.data.DefaultAbstractBag.markSpillableIfNecessary(DefaultAbstractBag.java:100)
    at org.apache.pig.data.InternalCachedBag.addDone(InternalCachedBag.java:131)
    at 
org.apache.pig.data.InternalCachedBag.iterator(InternalCachedBag.java:159)
    at org.apache.pig.test.TestDataBag.processDataBag(TestDataBag.java:1193)
    at 
org.apache.pig.test.TestDataBag.testDataBagIterIdempotent(TestDataBag.java:1145)
{code}
It looks like {{"/ by zero"}} is happening when j == 0 in the following code:
{code}
for (j = 0; i.hasNext() && j < 100; j++) { 
    avgTupleSize += i.next().getMemorySize();
}
avgTupleSize /= j;
{code}
                
> Trigger POPartialAgg compaction under GC pressure
> -------------------------------------------------
>
>                 Key: PIG-3044
>                 URL: https://issues.apache.org/jira/browse/PIG-3044
>             Project: Pig
>          Issue Type: Improvement
>    Affects Versions: 0.10.0, 0.11, 0.10.1
>            Reporter: Dmitriy V. Ryaboy
>            Assignee: Dmitriy V. Ryaboy
>             Fix For: 0.11, 0.12
>
>         Attachments: PIG-3044.2.diff, PIG-3404.diff
>
>
> If partial aggregation is turned on in pig 10 and 11, 20% (by default) of the 
> available heap can be consumed by the POPartialAgg operator. This can cause 
> memory issues for jobs that use all, or nearly all, of the heap already.
> If we make POPartialAgg "spillable" (trigger compaction when memory reduction 
> is required), we would be much nicer to high-memory jobs.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to