[ https://issues.apache.org/jira/browse/PIG-2857?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13530613#comment-13530613 ]
Cheolsoo Park commented on PIG-2857: ------------------------------------ Overall looks good to me. Two comments: - Can you update the doc ({{func.xml}}) too? We probably should keep {{tagsource}} yet indicate it as depreciated in the doc. - Can you update the comment of {{testPigStorageSourceTagSchema()}}? It still mentions {{tagsource}}. {code} /** * This is for testing source tagging option on PigStorage. When a user * specifies '-tagsource' as an option, PigStorage must prepend the input * source path to the tuple and "INPUT_FILE_NAME" to schema. * * @throws Exception */ {code} - Can you update the following line in {{testPigStorageSourceTagValue()}}? It still mentions {{tagsource}}. {code} assertEquals("tagsource value must be part-m-00000", inputFileName, storeFileName); {code} - Can you add some comment to code that tests {{-tagPath}} in {{testPigStorageSourceTagSchema()}} just to be clear? - Can you remove tabs in the patch? Thanks! > Add a -tagPath option to PigStorage > ----------------------------------- > > Key: PIG-2857 > URL: https://issues.apache.org/jira/browse/PIG-2857 > Project: Pig > Issue Type: New Feature > Reporter: Dmitriy V. Ryaboy > Assignee: Prashant Kommireddi > Attachments: PIG-2857_1.patch, PIG-2857.patch > > > We recently added a "-tagSource" option to PigStorage, which allows us to add > filenames from which records come to the returned tuples. > Often, users want the whole path, not just the source file. I propose we add > a "-tagPath" option to do this. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira