[
https://issues.apache.org/jira/browse/PIG-2857?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Cheolsoo Park updated PIG-2857:
-------------------------------
Attachment: PIG-2857_3.patch
Hi Prashant,
Thank you very much. I verified:
- The doc builds fine.
- ant test-commit passes.
- ant test -Dtestcase=TestPigStorage passes.
I am attaching a new patch where I removed tabs. I also made a minor change to
the PigStorage option parsing code as follows:
from
{code}
+ if (configuredOptions.hasOption("tagsource")) {
+ mLog.warn("'-tagsource' is deprecated. Use '-tagFile'
instead.");
+ }
isSchemaOn = configuredOptions.hasOption("schema");
dontLoadSchema = configuredOptions.hasOption("noschema");
- tagSource = configuredOptions.hasOption(TAG_SOURCE_PATH);
+ // Remove -tagsource in 0.13. For backward compatibility we need
+ // tagsource to be supported until at least 0.12
+ tagFile = configuredOptions.hasOption(TAG_SOURCE_FILE) ||
configuredOptions.hasOption("tagsource");
+ tagPath = configuredOptions.hasOption(TAG_SOURCE_PATH);
{code}
to
{code}
- tagSource = configuredOptions.hasOption(TAG_SOURCE_PATH);
+ tagFile = configuredOptions.hasOption(TAG_SOURCE_FILE);
+ tagPath = configuredOptions.hasOption(TAG_SOURCE_PATH);
+ // TODO: Remove -tagsource in 0.13. For backward compatibility, we
+ // need tagsource to be supported until at least 0.12
+ if (configuredOptions.hasOption("tagsource")) {
+ mLog.warn("'-tagsource' is deprecated. Use '-tagFile'
instead.");
+ tagFile = true;
+ }
{code}
If you're fine with the change, I will go ahead commit it.
> Add a -tagPath option to PigStorage
> -----------------------------------
>
> Key: PIG-2857
> URL: https://issues.apache.org/jira/browse/PIG-2857
> Project: Pig
> Issue Type: New Feature
> Reporter: Dmitriy V. Ryaboy
> Assignee: Prashant Kommireddi
> Attachments: PIG-2857_1.patch, PIG-2857_2.patch, PIG-2857_3.patch,
> PIG-2857.patch
>
>
> We recently added a "-tagSource" option to PigStorage, which allows us to add
> filenames from which records come to the returned tuples.
> Often, users want the whole path, not just the source file. I propose we add
> a "-tagPath" option to do this.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
