[ 
https://issues.apache.org/jira/browse/PIG-2553?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13531401#comment-13531401
 ] 

Prashant Kommireddi commented on PIG-2553:
------------------------------------------

Hi Cheolsoo, please see my comments below

1. Should we hold off on making this variable public until when needed? One 
could always modify scope in the future.
2. Good point. Will do
3. Returning String makes sense.
4. I feel like the new section would be a useful place for admins to go to, and 
we could keep adding properties that admins could/should be aware of. If its an 
overkill, I am fine with documenting pig.properties only. Let me know.

Again, thanks for reviewing.
                
> Pig shouldn't allow attempts to write multiple relations into same directory
> ----------------------------------------------------------------------------
>
>                 Key: PIG-2553
>                 URL: https://issues.apache.org/jira/browse/PIG-2553
>             Project: Pig
>          Issue Type: Improvement
>            Reporter: Dmitriy V. Ryaboy
>            Assignee: Prashant Kommireddi
>         Attachments: PIG-2553_1.patch, PIG-2553.patch
>
>
> We've seen multiple occasions where users accidentally try to store 2 or more 
> different relations to the same destination directory. Currently, this passes 
> the Pig planner and fails on MR side due to concurrent attempts to create the 
> same part file on the reducer. This is extremely confusing to the user, and 
> hard to debug.
> We should instead fail their scripts before they are even submitted, since we 
> can identify the erroneous condition from the beginning.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to