[ 
https://issues.apache.org/jira/browse/PIG-3091?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13536323#comment-13536323
 ] 

Jonathan Coveney commented on PIG-3091:
---------------------------------------

A minor nit, but since you add the new constructor, you can just do the 
following:
{code}
public JsonMetadata() {
    this(".pig_schema",".pig_header",".pig_stats");
}
{code}

The advantage being that if we change the logic around what to do with those 
file names, it can be kept in one place.
                
> Make schema, header and stats file configurable in JsonMetadata
> ---------------------------------------------------------------
>
>                 Key: PIG-3091
>                 URL: https://issues.apache.org/jira/browse/PIG-3091
>             Project: Pig
>          Issue Type: Improvement
>            Reporter: Prashant Kommireddi
>            Assignee: Prashant Kommireddi
>             Fix For: 0.12
>
>         Attachments: PIG-3091_1.patch, PIG-3091.patch
>
>
> JsonMetadata currently sets schema, header and stats file to the following
> {code}
>     private String schemaFileName = ".pig_schema";
>     private String headerFileName = ".pig_header";
>     private String statFileName = ".pig_stats";
> {code}
> This could be made configurable so users can create custom schema files (used 
> by custom Load/StoreFuncs)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to