[ 
https://issues.apache.org/jira/browse/PIG-2641?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13580135#comment-13580135
 ] 

Gunther Hagleitner commented on PIG-2641:
-----------------------------------------

- The test file only seems to test the json loader but not the actual ToJson 
function
- The json test input file doesn't seem to have all possible types
- There's already a TOMAP function - just wondering if the naming should be 
TOJSON
- There's copied code from JsonStorage. For easier maintenance, can you 
refactor to have both use the same code?
- I'm not sure about the bytearray datatype. It uses "toString" which will 
interpret the data as utf8 characters and return null if it's not legal UTF8. 
Is that the right thing to do for JSON? Base64? Refuse bytearray since Json 
doesn't support it?
                
> Create toJSON function for all complex types: tuples, bags and maps
> -------------------------------------------------------------------
>
>                 Key: PIG-2641
>                 URL: https://issues.apache.org/jira/browse/PIG-2641
>             Project: Pig
>          Issue Type: New Feature
>          Components: piggybank
>    Affects Versions: 0.12
>         Environment: Foggy. Damn foggy.
>            Reporter: Russell Jurney
>            Assignee: Russell Jurney
>              Labels: chararray, fun, happy, input, json, output, pants, pig, 
> piggybank, string, wonderdog
>             Fix For: 0.12
>
>         Attachments: PIG-2641.patch
>
>   Original Estimate: 96h
>  Remaining Estimate: 96h
>
> It is a travesty that there are no UDFs in Piggybanks that, given an 
> arbitrary Pig datatype, return a JSON string of same. I intend to fix this 
> problem.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to