[ 
https://issues.apache.org/jira/browse/PIG-3162?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Cheolsoo Park updated PIG-3162:
-------------------------------

    Status: Open  (was: Patch Available)

[~dreambird], can you please get rid of duplicate code? You can do something 
like this, for example:
{code}
public void assertOutput(String aliasInput, String[] input, String alias, 
String[] expected) throws IOException, ParseException {
    assertOutput(aliasInput, input, alias, expected, "\\t");
}
{code}
[~prkommireddi], that sounds like a good suggestion. Can we do it in another 
jira?
                
> PigTest.assertOutput doesn't allow non-default delimiter
> --------------------------------------------------------
>
>                 Key: PIG-3162
>                 URL: https://issues.apache.org/jira/browse/PIG-3162
>             Project: Pig
>          Issue Type: Bug
>          Components: tools
>    Affects Versions: 0.11
>            Reporter: Cheolsoo Park
>            Assignee: Johnny Zhang
>            Priority: Minor
>              Labels: newbie
>         Attachments: PIG-3162.nosw.patch.txt, PIG-3162.patch.txt
>
>
> {{PigTest.assertInput(String aliasInput, String[] input, String alias, 
> String[] expected)}} assumes that the default delimiter is used (i.e. tab 
> char) in input data.
> {code:title=TestPig.java}
> override(aliasInput, String.format(
>     "%s = LOAD '%s' AS %s;", aliasInput, destination, sb.toString()));
> {code}
> But it will be useful to be able to use a non-default delimiter. For example, 
> here is an email from the user mailing list:
> http://search-hadoop.com/m/Pxcfq1TrnIb/PigUnit+test+for+script+with+non-default+PigStorage+delimiter&subj=PigUnit+test+for+script+with+non+default+PigStorage+delimiter

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to