[ 
https://issues.apache.org/jira/browse/PIG-3261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13614934#comment-13614934
 ] 

Prashant Kommireddi commented on PIG-3261:
------------------------------------------

{quote}
IIRC the reason was to not have them step over the shipped library jars 
unintentionally with a simple HADOOP_CLASSPATH being set
{quote}

Based on that, I feel like keeping it simple and not having a toggle is better 
for following reasons:

# Pig does not have a env file like hadoop does for specifying CLASSPATH. Most 
likely this would be set by the user, would be intentional and not be picked up 
from any of pig's env files.
# Having a toggle for this seems like an additional step towards the same 
purpose. 

What do you think [~qwertymaniac]? It would be nice to have some others weight 
in on this. I am leaning more towards your initial patch, though I am not 
opposed to the latest patch either.

                
> User set PIG_CLASSPATH entries must be prepended to the CLASSPATH, not 
> appended
> -------------------------------------------------------------------------------
>
>                 Key: PIG-3261
>                 URL: https://issues.apache.org/jira/browse/PIG-3261
>             Project: Pig
>          Issue Type: Bug
>          Components: grunt
>    Affects Versions: 0.10.0
>            Reporter: Harsh J
>            Assignee: Harsh J
>         Attachments: PIG-3261.patch, PIG-3261.patch
>
>
> Currently we are doing this wrong:
> {code}
> if [ "$PIG_CLASSPATH" != "" ]; then
>     CLASSPATH=${CLASSPATH}:${PIG_CLASSPATH}
> {code}
> This means that anything added to CLASSPATH until that point will never be 
> able to get overridden by a user set environment, which is wrong behavior. 
> Hadoop libs for example are added to CLASSPATH, before this extension is 
> called in bin/pig.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to