----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10341/#review19085 -----------------------------------------------------------
Ship it! Neat! ANTLR magic! Just curious, dont we have a place (aka hooks) to modify the tree between queryparser and logicalplanbuilder? it would be nice to have something like that. - Aniket Mokashi On April 12, 2013, 1:42 a.m., Cheolsoo Park wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/10341/ > ----------------------------------------------------------- > > (Updated April 12, 2013, 1:42 a.m.) > > > Review request for pig. > > > Description > ------- > > Add SQL CASE statement to Pig. Please see: > https://issues.apache.org/jira/browse/PIG-3268 > > > This addresses bug PIG-3268. > https://issues.apache.org/jira/browse/PIG-3268 > > > Diffs > ----- > > src/org/apache/pig/parser/AliasMasker.g 9cc7971 > src/org/apache/pig/parser/AstPrinter.g 5d83bea > src/org/apache/pig/parser/AstValidator.g b85e238 > src/org/apache/pig/parser/LogicalPlanGenerator.g 26f13f6 > src/org/apache/pig/parser/QueryLexer.g c7f9fdd > src/org/apache/pig/parser/QueryParser.g 538621b > test/commit-tests 5081fbc > test/org/apache/pig/test/TestCase.java PRE-CREATION > > Diff: https://reviews.apache.org/r/10341/diff/ > > > Testing > ------- > > Added two new test suites: > - TestCase.java > - TestCaseUdf.java > > Also ran ant test-commit. > > > Thanks, > > Cheolsoo Park > >
