[ 
https://issues.apache.org/jira/browse/PIG-3286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13637393#comment-13637393
 ] 

Prashant Kommireddi commented on PIG-3286:
------------------------------------------

Looks good. +1 (non-binding)

Cheolsoo, would you like to clean up the unused import and Logger?

{code}
import static org.junit.Assert.fail;
{code}

{code}
    private static final Logger LOG = Logger.getLogger(TestPigContext.class);
{code}
                
> TestPigContext.testImportList fails in trunk
> --------------------------------------------
>
>                 Key: PIG-3286
>                 URL: https://issues.apache.org/jira/browse/PIG-3286
>             Project: Pig
>          Issue Type: Bug
>          Components: build
>    Affects Versions: 0.12
>            Reporter: Cheolsoo Park
>            Assignee: Cheolsoo Park
>              Labels: test
>             Fix For: 0.12
>
>         Attachments: PIG-3286.patch
>
>
> To reproduce, run ant clean test -Dtestcase=TestPigContext. It fails with the 
> following error:
> {code}
> junit.framework.AssertionFailedError: expected:<5> but was:<6>
>       at 
> org.apache.pig.test.TestPigContext.testImportList(TestPigContext.java:157)
> {code}
> This is a regression from PIG-3198 that added "java.lang." to the default 
> import list. Here is relevant code:
> {code}
> @@ -739,6 +739,7 @@ public class PigContext implements Serializable {
>          if (packageImportList.get() == null) {
>              ArrayList<String> importlist = new ArrayList<String>();
>              importlist.add("");
> +            importlist.add("java.lang.");
>              importlist.add("org.apache.pig.builtin.");
>              importlist.add("org.apache.pig.impl.builtin.");
>              packageImportList.set(importlist);
> {code}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to