-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11203/
-----------------------------------------------------------
Review request for pig, Daniel Dai, Dmitriy Ryaboy, Cheolsoo Park, and Bill
Graham.
Description
-------
Refactor physical operators to remove methods parameters that are always null
This addresses bug PIG-3307.
https://issues.apache.org/jira/browse/PIG-3307
Diffs
-----
src/org/apache/pig/backend/hadoop/executionengine/mapReduceLayer/MergeJoinIndexer.java
d5aff3d
src/org/apache/pig/backend/hadoop/executionengine/mapReduceLayer/PigCombiner.java
6cfc8c0
src/org/apache/pig/backend/hadoop/executionengine/mapReduceLayer/PigGenericMapBase.java
7c499f6
src/org/apache/pig/backend/hadoop/executionengine/mapReduceLayer/PigGenericMapReduce.java
6145214
src/org/apache/pig/backend/hadoop/executionengine/physicalLayer/PhysicalOperator.java
fc0112a
src/org/apache/pig/backend/hadoop/executionengine/physicalLayer/expressionOperators/Add.java
5bceca6
src/org/apache/pig/backend/hadoop/executionengine/physicalLayer/expressionOperators/BinaryComparisonOperator.java
3e434f3
src/org/apache/pig/backend/hadoop/executionengine/physicalLayer/expressionOperators/ComparisonOperator.java
51d9f34
src/org/apache/pig/backend/hadoop/executionengine/physicalLayer/expressionOperators/ConstantExpression.java
7e4cffa
src/org/apache/pig/backend/hadoop/executionengine/physicalLayer/expressionOperators/Divide.java
bdcc72b
src/org/apache/pig/backend/hadoop/executionengine/physicalLayer/expressionOperators/EqualToExpr.java
a767c36
src/org/apache/pig/backend/hadoop/executionengine/physicalLayer/expressionOperators/ExpressionOperator.java
9cca2c3
src/org/apache/pig/backend/hadoop/executionengine/physicalLayer/expressionOperators/GTOrEqualToExpr.java
b5e3c83
src/org/apache/pig/backend/hadoop/executionengine/physicalLayer/expressionOperators/GreaterThanExpr.java
f3b5d44
src/org/apache/pig/backend/hadoop/executionengine/physicalLayer/expressionOperators/LTOrEqualToExpr.java
35786c0
src/org/apache/pig/backend/hadoop/executionengine/physicalLayer/expressionOperators/LessThanExpr.java
c9b3157
src/org/apache/pig/backend/hadoop/executionengine/physicalLayer/expressionOperators/Mod.java
1108846
src/org/apache/pig/backend/hadoop/executionengine/physicalLayer/expressionOperators/Multiply.java
2795b78
src/org/apache/pig/backend/hadoop/executionengine/physicalLayer/expressionOperators/NotEqualToExpr.java
294f84a
src/org/apache/pig/backend/hadoop/executionengine/physicalLayer/expressionOperators/POAnd.java
f24c2ac
src/org/apache/pig/backend/hadoop/executionengine/physicalLayer/expressionOperators/POBinCond.java
312f3ac
src/org/apache/pig/backend/hadoop/executionengine/physicalLayer/expressionOperators/POCast.java
987cc21
src/org/apache/pig/backend/hadoop/executionengine/physicalLayer/expressionOperators/POIsNull.java
9ea89f7
src/org/apache/pig/backend/hadoop/executionengine/physicalLayer/expressionOperators/POMapLookUp.java
fd5573f
src/org/apache/pig/backend/hadoop/executionengine/physicalLayer/expressionOperators/PONegative.java
8d3fcb1
src/org/apache/pig/backend/hadoop/executionengine/physicalLayer/expressionOperators/PONot.java
973dfc5
src/org/apache/pig/backend/hadoop/executionengine/physicalLayer/expressionOperators/POOr.java
498eb12
src/org/apache/pig/backend/hadoop/executionengine/physicalLayer/expressionOperators/POProject.java
8886df7
src/org/apache/pig/backend/hadoop/executionengine/physicalLayer/expressionOperators/PORegexp.java
6634915
src/org/apache/pig/backend/hadoop/executionengine/physicalLayer/expressionOperators/PORelationToExprProject.java
e400a95
src/org/apache/pig/backend/hadoop/executionengine/physicalLayer/expressionOperators/POUserComparisonFunc.java
1aa1671
src/org/apache/pig/backend/hadoop/executionengine/physicalLayer/expressionOperators/POUserFunc.java
167cf06
src/org/apache/pig/backend/hadoop/executionengine/physicalLayer/expressionOperators/Subtract.java
4999995
src/org/apache/pig/backend/hadoop/executionengine/physicalLayer/relationalOperators/POCollectedGroup.java
a5adaf7
src/org/apache/pig/backend/hadoop/executionengine/physicalLayer/relationalOperators/POCombinerPackage.java
4a58a7e
src/org/apache/pig/backend/hadoop/executionengine/physicalLayer/relationalOperators/POCounter.java
30dcea2
src/org/apache/pig/backend/hadoop/executionengine/physicalLayer/relationalOperators/POCross.java
b90b0a2
src/org/apache/pig/backend/hadoop/executionengine/physicalLayer/relationalOperators/PODemux.java
e26c611
src/org/apache/pig/backend/hadoop/executionengine/physicalLayer/relationalOperators/PODistinct.java
ed2d39e
src/org/apache/pig/backend/hadoop/executionengine/physicalLayer/relationalOperators/POFRJoin.java
a4abdd8
src/org/apache/pig/backend/hadoop/executionengine/physicalLayer/relationalOperators/POFilter.java
552d6fa
src/org/apache/pig/backend/hadoop/executionengine/physicalLayer/relationalOperators/POForEach.java
45de398
src/org/apache/pig/backend/hadoop/executionengine/physicalLayer/relationalOperators/POGlobalRearrange.java
5fac709
src/org/apache/pig/backend/hadoop/executionengine/physicalLayer/relationalOperators/POJoinPackage.java
7e357ec
src/org/apache/pig/backend/hadoop/executionengine/physicalLayer/relationalOperators/POLimit.java
3a2542b
src/org/apache/pig/backend/hadoop/executionengine/physicalLayer/relationalOperators/POLoad.java
55bd896
src/org/apache/pig/backend/hadoop/executionengine/physicalLayer/relationalOperators/POLocalRearrange.java
88621ba
src/org/apache/pig/backend/hadoop/executionengine/physicalLayer/relationalOperators/POMergeCogroup.java
eea840a
src/org/apache/pig/backend/hadoop/executionengine/physicalLayer/relationalOperators/POMergeJoin.java
b6a4d96
src/org/apache/pig/backend/hadoop/executionengine/physicalLayer/relationalOperators/POMultiQueryPackage.java
57a56fa
src/org/apache/pig/backend/hadoop/executionengine/physicalLayer/relationalOperators/POOptimizedForEach.java
91b3f00
src/org/apache/pig/backend/hadoop/executionengine/physicalLayer/relationalOperators/POPackage.java
e755e2a
src/org/apache/pig/backend/hadoop/executionengine/physicalLayer/relationalOperators/POPackageLite.java
e17d547
src/org/apache/pig/backend/hadoop/executionengine/physicalLayer/relationalOperators/POPartialAgg.java
b909dc0
src/org/apache/pig/backend/hadoop/executionengine/physicalLayer/relationalOperators/POPartitionRearrange.java
5227d55
src/org/apache/pig/backend/hadoop/executionengine/physicalLayer/relationalOperators/POPreCombinerLocalRearrange.java
59b032f
src/org/apache/pig/backend/hadoop/executionengine/physicalLayer/relationalOperators/PORank.java
9e3d1eb
src/org/apache/pig/backend/hadoop/executionengine/physicalLayer/relationalOperators/POSort.java
c76236b
src/org/apache/pig/backend/hadoop/executionengine/physicalLayer/relationalOperators/POSortedDistinct.java
8000c9a
src/org/apache/pig/backend/hadoop/executionengine/physicalLayer/relationalOperators/POSplit.java
de2c972
src/org/apache/pig/backend/hadoop/executionengine/physicalLayer/relationalOperators/POStore.java
249aecb
src/org/apache/pig/backend/hadoop/executionengine/physicalLayer/relationalOperators/POStream.java
894dc7d
src/org/apache/pig/backend/hadoop/executionengine/physicalLayer/relationalOperators/POUnion.java
508daef
src/org/apache/pig/impl/builtin/DefaultIndexableLoader.java e2d3b86
test/org/apache/pig/test/PORead.java e4a07dd
test/org/apache/pig/test/TestAdd.java a80ef81
test/org/apache/pig/test/TestBoolean.java 4e70e21
test/org/apache/pig/test/TestCharArrayToNumeric.java 473599d
test/org/apache/pig/test/TestConstExpr.java d18c419
test/org/apache/pig/test/TestDivide.java 48b1591
test/org/apache/pig/test/TestEqualTo.java 2e3584b
test/org/apache/pig/test/TestFRJoin.java 2bf868e
test/org/apache/pig/test/TestFilter.java 9e6ce32
test/org/apache/pig/test/TestForEach.java 317b9e7
test/org/apache/pig/test/TestGTOrEqual.java c1a3f6d
test/org/apache/pig/test/TestGreaterThan.java 77bd3f0
test/org/apache/pig/test/TestLTOrEqual.java 84a72ee
test/org/apache/pig/test/TestLessThan.java d57cbb7
test/org/apache/pig/test/TestLoad.java 6faf94e
test/org/apache/pig/test/TestLocalRearrange.java b471463
test/org/apache/pig/test/TestMod.java 995a6ba
test/org/apache/pig/test/TestMultiply.java deeba8b
test/org/apache/pig/test/TestNotEqualTo.java 6417d68
test/org/apache/pig/test/TestNull.java 17f4408
test/org/apache/pig/test/TestPOBinCond.java 65c6a0d
test/org/apache/pig/test/TestPOCast.java 1d5f7e9
test/org/apache/pig/test/TestPODistinct.java 3168486
test/org/apache/pig/test/TestPOGenerate.java cfe2347
test/org/apache/pig/test/TestPOMapLookUp.java 7c6cd64
test/org/apache/pig/test/TestPONegative.java 2e06947
test/org/apache/pig/test/TestPOPartialAgg.java 6645952
test/org/apache/pig/test/TestPOSort.java 756865e
test/org/apache/pig/test/TestPOSplit.java 71fb089
test/org/apache/pig/test/TestPOUserFunc.java 77eab4e
test/org/apache/pig/test/TestPackage.java 984cd49
test/org/apache/pig/test/TestProject.java ff7eedf
test/org/apache/pig/test/TestRegexp.java 0737f5e
test/org/apache/pig/test/TestSubtract.java f0a253b
test/org/apache/pig/test/TestUnion.java 339b459
test/org/apache/pig/test/utils/POCastDummy.java b83ed51
test/org/apache/pig/test/utils/TestHelper.java 1efabbe
Diff: https://reviews.apache.org/r/11203/diff/
Testing
-------
test-commit
Thanks,
Julien Le Dem