[
https://issues.apache.org/jira/browse/PIG-3258?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Cheolsoo Park updated PIG-3258:
-------------------------------
Assignee: Joel Fouse
[~jfouse], thank you very much for the patch! It looks good.
But the test doesn't pass for me. I briefly debugged it, and it seems that
starting up/tearing down the mini cluster for every test case is causing a
problem.
{code}
Testcase: testMultiStorageMultiLevel took 0.002 sec
Caused an ERROR
function called on MiniCluster that has been shutdown
java.lang.RuntimeException: function called on MiniCluster that has been
shutdown
at
org.apache.pig.test.MiniGenericCluster.errorIfNotSetup(MiniGenericCluster.java:120)
at
org.apache.pig.test.MiniGenericCluster.getFileSystem(MiniGenericCluster.java:109)
at org.apache.pig.test.Util.deleteFile(Util.java:437)
at
org.apache.pig.piggybank.test.storage.TestMultiStorage.createFile(TestMultiStorage.java:80)
at
org.apache.pig.piggybank.test.storage.TestMultiStorage.setUp(TestMultiStorage.java:95)
{code}
Can you change setUp() and tearDown() to static and annotate them with
@BeforeClass and @AfterClass respectively? You will need to change a couple of
variables to static too.
Regarding filename, what you propose seems reasonable. How about resolving it
in a separate jira after committing this one first? Let me know what you think.
> Patch to allow MultiStorage to use more than one index to generate output tree
> ------------------------------------------------------------------------------
>
> Key: PIG-3258
> URL: https://issues.apache.org/jira/browse/PIG-3258
> Project: Pig
> Issue Type: Improvement
> Components: piggybank
> Reporter: Joel Fouse
> Assignee: Joel Fouse
> Priority: Minor
> Labels: piggybank
> Attachments: MultiStorageMultiIndex.patch
>
>
> I have made a patch to enable MultiStorage to handle multiple tuple indexes,
> rather than only one, for generating the output directory structure. Before
> I submit it, though, I need to know if I should generate the patch from
> /contrib/piggybank/java where I've been compiling and unit testing, or back
> at the project root.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
