----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11355/#review21315 -----------------------------------------------------------
http://svn.apache.org/repos/asf/pig/trunk/contrib/piggybank/java/src/main/java/org/apache/pig/piggybank/storage/avro/PigSchema2Avro.java <https://reviews.apache.org/r/11355/#comment44213> Initialize defaultValue in a variable and pass defaultValue instead of doing a if else condition. http://svn.apache.org/repos/asf/pig/trunk/contrib/piggybank/java/src/test/java/org/apache/pig/piggybank/test/storage/avro/TestAvroStorage.java <https://reviews.apache.org/r/11355/#comment44215> Isn't a load and store enough to reproduce the test case? Why such a long pig script? Please try to keep the unit tests simple. - Rohini Palaniswamy On May 30, 2013, 2:29 a.m., Viraj Bhat wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/11355/ > ----------------------------------------------------------- > > (Updated May 30, 2013, 2:29 a.m.) > > > Review request for pig and Rohini Palaniswamy. > > > Description > ------- > > Patch to write default values to the Schema when the writer schema contains > that in the AvroStorage. > > > Diffs > ----- > > > http://svn.apache.org/repos/asf/pig/trunk/contrib/piggybank/java/src/main/java/org/apache/pig/piggybank/storage/avro/PigSchema2Avro.java > 1485826 > > http://svn.apache.org/repos/asf/pig/trunk/contrib/piggybank/java/src/test/java/org/apache/pig/piggybank/test/storage/avro/TestAvroStorage.java > 1485826 > > http://svn.apache.org/repos/asf/pig/trunk/contrib/piggybank/java/src/test/java/org/apache/pig/piggybank/test/storage/avro/avro_test_files/numbers.txt > PRE-CREATION > > Diff: https://reviews.apache.org/r/11355/diff/ > > > Testing > ------- > > Yes against the Piggybank in Pig trunk/Pig 0.12 > > > Thanks, > > Viraj Bhat > >
