[ 
https://issues.apache.org/jira/browse/PIG-3065?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13702632#comment-13702632
 ] 

Rohini Palaniswamy commented on PIG-3065:
-----------------------------------------

Few comments:
  1) Can you change static public to public static in HadoopShims?
  2) You are checking against the static string instead of the value in the 
configuration. It will never be true.

supported = PigConfiguration.PIG_OUTPUT_COMMITTER_RECOVERY.equals("true") ? 
HadoopShims.isRecoverySupported(oc) : false;
   
  Were you able to test this out by killing the application master process? It 
needs to be tested out for this patch to be ready for commit.  
                
> pig output format/committer should support recovery for hadoop 0.23
> -------------------------------------------------------------------
>
>                 Key: PIG-3065
>                 URL: https://issues.apache.org/jira/browse/PIG-3065
>             Project: Pig
>          Issue Type: New Feature
>            Reporter: Rohini Palaniswamy
>            Assignee: Johnny Zhang
>            Priority: Minor
>         Attachments: PIG-3065.patch.txt
>
>
> In hadoop 0.23 the output committer can optionally support recovery to handle
> the application master getting restarted (failing some # of attempts). If its 
> possible the pig outputformat/committer should support recovery.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to