[
https://issues.apache.org/jira/browse/PIG-3359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13714627#comment-13714627
]
Cheolsoo Park commented on PIG-3359:
------------------------------------
Great! I just confirmed all unit tests pass now. Thank you!
I have one last suggestion. Can you make this changes?
https://github.com/piaozhexiu/apache-pig/commit/9e7c9ec9b70fa902ad4adc1dcf337762a8a14d3a
While doing more testing, I discovered few more corner cases (see my comments
on RB) that break your implementation. In addition, I realized that there is no
need to re-implement the doParamSubstitutionForMacroFile() method after all. So
I made the above changes to your patch, and your test scripts still work.
Thanks!
> Register Statements and Param Substitution in Macros
> ----------------------------------------------------
>
> Key: PIG-3359
> URL: https://issues.apache.org/jira/browse/PIG-3359
> Project: Pig
> Issue Type: Bug
> Components: parser
> Reporter: Jonathan Packer
> Assignee: Jonathan Packer
> Attachments: PIG-3359_test.tar.gz, PIG-3359-v1.diff,
> PIG-3359-v2.diff, PIG-3359-v3.diff, PIG-3359-v3-test-failures.txt,
> PIG-3359-v4.diff
>
>
> There are some gaps in the functionality of macros that I've made a patch to
> address. The goal is to provide everything you'd need to make reusable
> algorithms libraries.
> 1. You can't register udfs inside a macro
> 2. Paramater substitutions aren't done inside macros
> 3. Resources (including macros) should not be redundantly acquired if they
> are already present.
> Rohini's patch https://issues.apache.org/jira/browse/PIG-3204 should address
> problem 3 where Pig reparses everything every time it reads a line, but there
> still would be a problem if two separate files import the same macro / udf
> file.
> To get this working, I moved methods for registering jars/udfs and param
> substitution from PigServer to PigContext so they can be accessed in
> QueryParserDriver which processes macros (QPD was already passed a PigContext
> reference). Is that ok?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
