[
https://issues.apache.org/jira/browse/PIG-3390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13720325#comment-13720325
]
Cheolsoo Park commented on PIG-3390:
------------------------------------
[~jarcec], thank you for the patch sir! It's unfortunate that we have to rely
on reflection to detect the version, but if there's no better way, that's what
it is... :( I have few comments as below though.
# I think you made mistakes in ivy.xml. It doesn't compile.
{code}
+ <exclude org="org.sl <!--Private configurations. -->f4j"
module="slf4j"/>
{code}
# Can you change "hbase.version" to "hbase94.version" in libraries.properties?
# Do you mind explaining what these jars are for? Are they needed?
{code}
+ <dependency org="org.cloudera.htrace" name="htrace" rev="1.50"
conf="hbasecompat1->master">
+ <artifact name="hbase-hadoop1-compat" type="jar"/>
+ </dependency>
+
+ <dependency org="org.cloudera.htrace" name="htrace" rev="1.50"
conf="hbasecompat2->master">
+ <artifact name="hbase-hadoop2-compat" type="jar"/>
+ </dependency>
{code}
# Let's not add support for hadoop2 yet. We can revisit when hbase jars are
available. TestHBaseStorage is excluded in hadoop2 unit tests anyway.
# Can you remove unused imports in TestHbaseStorage.java and HbaseStorage.java?
# Can you use 4-space indentation instead of 2-space?
> Make pig working with HBase 0.95
> --------------------------------
>
> Key: PIG-3390
> URL: https://issues.apache.org/jira/browse/PIG-3390
> Project: Pig
> Issue Type: New Feature
> Reporter: Jarek Jarcec Cecho
> Assignee: Jarek Jarcec Cecho
> Attachments: PIG-3390.patch
>
>
> The HBase 0.95 changed API in incompatible way. Following APIs that
> {{HBaseStorage}} in Pig uses are no longer available:
> * {{Mutation.setWriteToWAL(Boolean)}}
> * {{Scan.write(DataOutput)}}
> Also in addition the HBase is no longer available as one monolithic archive
> with entire functionality, but was broken down into smaller pieces such as
> {{hbase-client}}, {{hbase-server}}, ...
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
