----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14472/#review26685 -----------------------------------------------------------
src/org/apache/pig/backend/hadoop/hbase/HBaseStorage.java <https://reviews.apache.org/r/14472/#comment51974> Do we need vendor specific class here? src/org/apache/pig/backend/hadoop/hbase/HBaseStorage.java <https://reviews.apache.org/r/14472/#comment51975> The whole thing seems a hack to me. Do we have to do this this way? src/org/apache/pig/backend/hadoop/hbase/HBaseStorage.java <https://reviews.apache.org/r/14472/#comment51978> Will old version of HBase continue working? - Xuefu Zhang On Oct. 3, 2013, 9:59 p.m., Jarek Cecho wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/14472/ > ----------------------------------------------------------- > > (Updated Oct. 3, 2013, 9:59 p.m.) > > > Review request for pig. > > > Bugs: PIG-3496 > https://issues.apache.org/jira/browse/PIG-3496 > > > Repository: pig-git > > > Description > ------- > > I've added the additional required jars into the > initialiseHBaseClassLoaderResources() method, so that they get propagated > into the backend. > > > Diffs > ----- > > src/org/apache/pig/backend/hadoop/hbase/HBaseStorage.java 67aa984 > > Diff: https://reviews.apache.org/r/14472/diff/ > > > Testing > ------- > > Unit tests for both hbaseversion = 94 | 95 seems to be passing: > > ant clean test -Dtestcase=TestHBaseStorage -Dhbaseversion=94 > -Dprotobuf-java.version=2.4.0a > ant clean test -Dtestcase=TestHBaseStorage -Dhbaseversion=95 > -Dprotobuf-java.version=2.5.0 > > I've also tried the patch on fully distributed clusters running both major > HBase versions and everything seems to be working. > > > Thanks, > > Jarek Cecho > >
