----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12321/#review27215 -----------------------------------------------------------
src/org/apache/pig/backend/hadoop/executionengine/physicalLayer/expressionOperators/POIsNull.java <https://reviews.apache.org/r/12321/#comment52929> Wouldn't this affect behavior of POIsNull for all other use cases? For example- filter. - Aniket Mokashi On July 7, 2013, 8:43 p.m., Cheolsoo Park wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/12321/ > ----------------------------------------------------------- > > (Updated July 7, 2013, 8:43 p.m.) > > > Review request for pig. > > > Bugs: PIG-3021 > https://issues.apache.org/jira/browse/PIG-3021 > > > Repository: pig-git > > > Description > ------- > > Introduced a new optional keyword (ALL) into the split otherwise. If ALL is > specified, null values are stored into the default relation. Otherwise, nulls > are discarded. By default, ALL is not specified. > > > Diffs > ----- > > src/docs/src/documentation/content/xdocs/basic.xml e78bbd8 > > src/org/apache/pig/backend/hadoop/executionengine/physicalLayer/expressionOperators/POIsNull.java > 4b38b45 > src/org/apache/pig/parser/AstPrinter.g ccccd87 > src/org/apache/pig/parser/AstValidator.g d0ed0e8 > src/org/apache/pig/parser/LogicalPlanBuilder.java 99e481d > src/org/apache/pig/parser/LogicalPlanGenerator.g b13f346 > src/org/apache/pig/parser/QueryParser.g d4d9700 > test/org/apache/pig/test/TestSplit.java 8794110 > > Diff: https://reviews.apache.org/r/12321/diff/ > > > Testing > ------- > > Added a test case to TestSplit regarding the new keyword. > > ant test -Dtestcase=TestSplit passes. > > > Thanks, > > Cheolsoo Park > >
