[
https://issues.apache.org/jira/browse/PIG-3569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13821666#comment-13821666
]
Rohini Palaniswamy commented on PIG-3569:
-----------------------------------------
Thanks for the clarification. We can address that in a different jira.
Few comments:
1) //Memory Management? - That is not required. You can remove setting values
to null as it is not a big object and java GC should handle that easily.
2) BigDecimal d = ((BigDecimal) n).add(BigDecimal.ZERO);
Why do you have to add zero? Isn't typecast just enough?
3) AlgebraicBigDecimalSumBase - Can you please rename to
AlgebraicBigDecimalMathBase and also correct the javadoc to reflect that, so
that we can use this class to add MIN and MAX in a different jira in future.
4) Please make a copy of that code for BigInteger as well.
5) Please update testSUM* testcases in TestBuiltin.java for BigInteger and
BigDecimal.
> SUM function for BigDecimal
> ---------------------------
>
> Key: PIG-3569
> URL: https://issues.apache.org/jira/browse/PIG-3569
> Project: Pig
> Issue Type: Improvement
> Components: internal-udfs
> Affects Versions: 0.12.0
> Reporter: Hariharasudhan Chinnan
> Assignee: Hariharasudhan Chinnan
> Priority: Critical
> Fix For: 0.13.0
>
> Attachments: PIG_3569.patch
>
>
> SUM function doesn't support newly added BigDecimal data type. I've a patch
> to make SUM function work for BigDecimal
--
This message was sent by Atlassian JIRA
(v6.1#6144)
