[ 
https://issues.apache.org/jira/browse/PIG-3616?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Cheolsoo Park updated PIG-3616:
-------------------------------

    Attachment: PIG-3616-2.patch

[~lbendig], thank you for finding this. I see the problem.

I have two minor comments on your patch-
# Can we generate the input file to local instead of making the test run in mr 
mode? I prefer local mode to mr mode if possible since the latter is slower.
# Can we move FileLocalizer.reset(null) to setup()? That will let not only this 
test but also every test run w/o a side effect in the future.

I am uploading a patch that addresses my comments and will commit this if you 
have no objection. Let me know.


> TestBuiltIn.testURIwithCurlyBrace() silently fails
> --------------------------------------------------
>
>                 Key: PIG-3616
>                 URL: https://issues.apache.org/jira/browse/PIG-3616
>             Project: Pig
>          Issue Type: Bug
>    Affects Versions: 0.12.0
>            Reporter: Lorand Bendig
>            Assignee: Lorand Bendig
>            Priority: Minor
>              Labels: test
>             Fix For: 0.13.0
>
>         Attachments: PIG-3616-2.patch, PIG-3616.patch
>
>
> This test runs against MiniCluster but takes the input from the local path.
> The empty catch block swallows the exception ("input path does not exist") 
> thus making a false negative result.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Reply via email to