[
https://issues.apache.org/jira/browse/PIG-259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13890971#comment-13890971
]
Daniel Dai commented on PIG-259:
--------------------------------
Thanks for the update. Another several comments:
1. PigOutputFormat.java: Remove "PigStorage ps = (PigStorage) sFunc;", we
cannot assume sFunc is PigStorage
2. InputOutputFileValidator.java: Shall we skip checkOutputSpecs when overwrite
happens? There is nothing wrong to capture FileAlreadyExistsException
exception, but since you skip checkOutputSpecs in PigOutputFormat, it seems
better to do it consistently
3. Another tab in PigStorage.java: "protected ResourceSchema schema"
> allow store to overwrite existing directroy
> -------------------------------------------
>
> Key: PIG-259
> URL: https://issues.apache.org/jira/browse/PIG-259
> Project: Pig
> Issue Type: Sub-task
> Reporter: Olga Natkovich
> Assignee: Nezih Yigitbasi
> Attachments: PIG-259.5.patch, PIG-259.6.patch, Pig_259.patch,
> Pig_259_2.patch, Pig_259_3.patch, Pig_259_4.patch
>
>
> we have users who are asking for a flag to overwrite existing directory
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
