[ 
https://issues.apache.org/jira/browse/PIG-3456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13896199#comment-13896199
 ] 

Dmitriy V. Ryaboy commented on PIG-3456:
----------------------------------------

Added a couple minor comments. Good change overall.

BTW not sure if you saw, but PIG-3325 addressed the bag insertion regression 
you saw as a side effect of PIG-2923 without sacrificing the memory and gc 
benefits 2923 provides, so if you still have that reverted in your build, 
consider un-reverting..

> Reduce threadlocal conf access in backend for each record
> ---------------------------------------------------------
>
>                 Key: PIG-3456
>                 URL: https://issues.apache.org/jira/browse/PIG-3456
>             Project: Pig
>          Issue Type: Improvement
>    Affects Versions: 0.11.1
>            Reporter: Rohini Palaniswamy
>            Assignee: Rohini Palaniswamy
>             Fix For: 0.13.0
>
>         Attachments: PIG-3456-1-no-whitespace.patch, PIG-3456-1.patch
>
>
> Noticed few things while browsing code
> 1) DefaultTuple has a protected boolean isNull = false; which is never used. 
> Removing this gives ~3-5% improvement for big jobs
> 2) Config checking with ThreadLocal conf is repeatedly done for each record. 
> For eg: createDataBag in POCombinerPackage. But initialized only for first 
> time in other places like POPackage, POJoinPackage, etc.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Reply via email to