----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17958/#review34242 -----------------------------------------------------------
Ship it! Please just make the minor change and go ahead with the commit. Just upload the final patch in the jira, in case someone wants to take it and apply later. src/org/apache/pig/backend/hadoop/executionengine/tez/TezDagBuilder.java <https://reviews.apache.org/r/17958/#comment64268> new Job(ConfigurationUtil.toConfiguration(pc.getProperties(), false)); src/org/apache/pig/backend/hadoop/executionengine/tez/TezDagBuilder.java <https://reviews.apache.org/r/17958/#comment64269> This can be removed and conf directly passed when doing new Job() as above comment. - Rohini Palaniswamy On Feb. 11, 2014, 7:42 p.m., Mark Wagner wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/17958/ > ----------------------------------------------------------- > > (Updated Feb. 11, 2014, 7:42 p.m.) > > > Review request for pig, Alex Bain, Cheolsoo Park, Daniel Dai, and Rohini > Palaniswamy. > > > Bugs: PIG-3768 > https://issues.apache.org/jira/browse/PIG-3768 > > > Repository: pig-git > > > Description > ------- > > Instead of creating empty configurations, initialize configurations with the > properties provided by the user. > > > Diffs > ----- > > src/org/apache/pig/backend/hadoop/executionengine/tez/TezDagBuilder.java > b3e74d9 > > Diff: https://reviews.apache.org/r/17958/diff/ > > > Testing > ------- > > Ran test-commit, and ran a script that wasn't respecting memory setting > before, which succeeded after the patch. > > > Thanks, > > Mark Wagner > >
