[
https://issues.apache.org/jira/browse/PIG-3844?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13955934#comment-13955934
]
Akihiro Matsukawa commented on PIG-3844:
----------------------------------------
Actually, [~prkommireddi] [~cheolsoo] I began to write the test to simulate our
PPNL, but I realized all it does is call functions MRScriptState.get().getAlias
and MRScriptState.getFeature, so the "test" would just be to spin off a new
thread and make sure we can call those methods, but it seems like that's just
testing that InheritableThreadLocal works.
What are your thoughts?
> Make ScriptState InheritableThreadLocal for threads that need it
> ----------------------------------------------------------------
>
> Key: PIG-3844
> URL: https://issues.apache.org/jira/browse/PIG-3844
> Project: Pig
> Issue Type: Improvement
> Reporter: Akihiro Matsukawa
> Assignee: Akihiro Matsukawa
> Attachments: PIG-3844.patch
>
>
> I have a PPNL that is forked off the main thread so that its operations does
> not block pig from continuing to run. This PPNL needs the ScriptState, but is
> not able to get it in pig13 because the ScriptState is ThreadLocal.
> In pig12, this worked because there was logic to start a new ScriptState on
> ScriptState.get() which was removed in PIG-3525
> (https://reviews.apache.org/r/15634).
> My proposal is to change ScriptState to be InheritableThreadLocal, so that
> any new child threads that are spawned will have a copy of it. I have a
> pretty limited understanding of pig, but I do not see anything that this
> proposed change would break.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
