[
https://issues.apache.org/jira/browse/PIG-3591?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13960931#comment-13960931
]
Cheolsoo Park commented on PIG-3591:
------------------------------------
+1. Thank you so much for the great work! I have one minor comment below.
When you commit, do you mind fixing the following test case? Shouldn't
"distinct A" to be "order A by x"? I see another testDistinct() in the test
suite that tests distinct, so it looks like this test case is supposed to test
order by. Please correct me if I am wrong.
{code:title=TestExampleGenerator.java}
+ @Test
+ public void testOrderBy() throws Exception {
+ PigServer pigServer = new PigServer(pigContext);
+ pigServer.registerQuery("A = load " + A.toString() + " as (x, y);");
+ pigServer.registerQuery("B = distinct A;");
+ Map<Operator, DataBag> derivedData = pigServer.getExamples("B");
+
assertNotNull(derivedData);
}
{code}
> Refactor POPackage to separate MR specific code from packaging
> --------------------------------------------------------------
>
> Key: PIG-3591
> URL: https://issues.apache.org/jira/browse/PIG-3591
> Project: Pig
> Issue Type: Bug
> Reporter: Mark Wagner
> Assignee: Mark Wagner
> Attachments: PIG-3591.1.patch, PIG-3591.2.patch, PIG-3591.5.patch
>
>
> POPackage is currently closely associated with the MR shuffle semantics. This
> makes it difficult to adapt the variety of subclasses of POPackage to other
> execution engines without duplicating code.
--
This message was sent by Atlassian JIRA
(v6.2#6252)