[ 
https://issues.apache.org/jira/browse/PIG-3672?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13980606#comment-13980606
 ] 

Daniel Dai commented on PIG-3672:
---------------------------------

+1 for PIG-3672-3.patch



> Pig should not check for hardcoded file system implementations
> --------------------------------------------------------------
>
>                 Key: PIG-3672
>                 URL: https://issues.apache.org/jira/browse/PIG-3672
>             Project: Pig
>          Issue Type: Bug
>          Components: data, parser
>    Affects Versions: 0.10.0, 0.12.0, 0.11.1
>            Reporter: Suhas Satish
>            Assignee: Rohini Palaniswamy
>             Fix For: 0.13.0
>
>         Attachments: PIG-3672-1.patch, PIG-3672-2.patch, PIG-3672-3.patch, 
> PIG-3672.patch
>
>
> QueryParserUtils.java has the code - 
> result.add("hdfs://"+thisHost+":"+uri.getPort());
> I propose to make it generic like - 
> result.add(uri.getScheme() + "://"+thisHost+":"+uri.getPort());
> Similarly jobControlCompiler.java has - 
> if (!outputPathString.contains("://") || 
> outputPathString.startsWith("hdfs://")) {
>  I have a patch version which I ran passing unit tests on. Will be uploading 
> it shortly.  



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to