----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21405/#review42935 -----------------------------------------------------------
http://svn.apache.org/repos/asf/pig/branches/tez/src/org/apache/pig/backend/hadoop/executionengine/tez/TezDagBuilder.java <https://reviews.apache.org/r/21405/#comment76883> Indentation looks funny. http://svn.apache.org/repos/asf/pig/branches/tez/src/org/apache/pig/backend/hadoop/executionengine/tez/TezDagBuilder.java <https://reviews.apache.org/r/21405/#comment76876> Why use BooleanWritableComparator for BigDecimal and BigInteger? http://svn.apache.org/repos/asf/pig/branches/tez/src/org/apache/pig/backend/hadoop/executionengine/tez/TezDagBuilder.java <https://reviews.apache.org/r/21405/#comment76877> Why not DoubleWritableComparator? - Cheolsoo Park On May 13, 2014, 8:49 p.m., Rohini Palaniswamy wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/21405/ > ----------------------------------------------------------- > > (Updated May 13, 2014, 8:49 p.m.) > > > Review request for pig, Cheolsoo Park and Daniel Dai. > > > Bugs: PIG-3925 > https://issues.apache.org/jira/browse/PIG-3925 > > > Repository: pig > > > Description > ------- > > Ported following test cases > TestFRJoin.java > TestFRJoinNullValue.java > TestGrunt.java > TestImplicitSplit.java > TestInputOutputMiniClusterFileValidator.java > TestJoin.java > TestJoinSmoke.java > TestKeyTypeDiscoveryVisitor.java > TestNewPlanImplicitSplit.java > TestPigServerWithMacros.java > TestRegisteredJarVisibility.java > TestStoreInstances.java > TestToolsPigServer.java > > Also turn off opt.fetch for tez tests as some tests were passing because of > that without running on Tez. > > > Diffs > ----- > > http://svn.apache.org/repos/asf/pig/branches/tez/build.xml 1593885 > > http://svn.apache.org/repos/asf/pig/branches/tez/shims/test/hadoop23/org/apache/pig/test/TezMiniCluster.java > 1593885 > > http://svn.apache.org/repos/asf/pig/branches/tez/src/org/apache/pig/backend/hadoop/executionengine/mapReduceLayer/JobControlCompiler.java > 1593885 > > http://svn.apache.org/repos/asf/pig/branches/tez/src/org/apache/pig/backend/hadoop/executionengine/mapReduceLayer/PigInputFormat.java > 1593885 > > http://svn.apache.org/repos/asf/pig/branches/tez/src/org/apache/pig/backend/hadoop/executionengine/tez/POFRJoinTez.java > 1593885 > > http://svn.apache.org/repos/asf/pig/branches/tez/src/org/apache/pig/backend/hadoop/executionengine/tez/POStoreTez.java > 1593885 > > http://svn.apache.org/repos/asf/pig/branches/tez/src/org/apache/pig/backend/hadoop/executionengine/tez/PigProcessor.java > 1593885 > > http://svn.apache.org/repos/asf/pig/branches/tez/src/org/apache/pig/backend/hadoop/executionengine/tez/TezDagBuilder.java > 1593885 > > http://svn.apache.org/repos/asf/pig/branches/tez/src/org/apache/pig/impl/PigContext.java > 1593885 > > http://svn.apache.org/repos/asf/pig/branches/tez/test/org/apache/pig/test/TestBuiltin.java > 1593885 > > http://svn.apache.org/repos/asf/pig/branches/tez/test/org/apache/pig/test/TestFRJoin.java > 1593885 > > http://svn.apache.org/repos/asf/pig/branches/tez/test/org/apache/pig/test/TestFRJoin2.java > 1593885 > > http://svn.apache.org/repos/asf/pig/branches/tez/test/org/apache/pig/test/TestFRJoinNullValue.java > 1593885 > > http://svn.apache.org/repos/asf/pig/branches/tez/test/org/apache/pig/test/TestGrunt.java > 1593885 > > http://svn.apache.org/repos/asf/pig/branches/tez/test/org/apache/pig/test/TestImplicitSplit.java > 1593885 > > http://svn.apache.org/repos/asf/pig/branches/tez/test/org/apache/pig/test/TestInputOutputMiniClusterFileValidator.java > 1593885 > > http://svn.apache.org/repos/asf/pig/branches/tez/test/org/apache/pig/test/TestJoin.java > 1593885 > > http://svn.apache.org/repos/asf/pig/branches/tez/test/org/apache/pig/test/TestJoinSmoke.java > 1593885 > > http://svn.apache.org/repos/asf/pig/branches/tez/test/org/apache/pig/test/TestKeyTypeDiscoveryVisitor.java > 1593885 > > http://svn.apache.org/repos/asf/pig/branches/tez/test/org/apache/pig/test/TestNewPlanImplicitSplit.java > 1593885 > > http://svn.apache.org/repos/asf/pig/branches/tez/test/org/apache/pig/test/TestPigContext.java > 1593885 > > http://svn.apache.org/repos/asf/pig/branches/tez/test/org/apache/pig/test/TestPigServerWithMacros.java > 1593885 > > http://svn.apache.org/repos/asf/pig/branches/tez/test/org/apache/pig/test/TestPigStorage.java > 1593885 > > http://svn.apache.org/repos/asf/pig/branches/tez/test/org/apache/pig/test/TestPoissonSampleLoader.java > 1593885 > > http://svn.apache.org/repos/asf/pig/branches/tez/test/org/apache/pig/test/TestRegisteredJarVisibility.java > 1593885 > > http://svn.apache.org/repos/asf/pig/branches/tez/test/org/apache/pig/test/TestStoreInstances.java > 1593885 > > http://svn.apache.org/repos/asf/pig/branches/tez/test/org/apache/pig/test/TestToolsPigServer.java > 1593885 > > http://svn.apache.org/repos/asf/pig/branches/tez/test/org/apache/pig/test/Util.java > 1593885 > http://svn.apache.org/repos/asf/pig/branches/tez/test/tez-tests 1593885 > > Diff: https://reviews.apache.org/r/21405/diff/ > > > Testing > ------- > > Unit tests are fine. Running full e2e now. > > > Thanks, > > Rohini Palaniswamy > >
