[
https://issues.apache.org/jira/browse/PIG-3545?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Daniel Dai resolved PIG-3545.
-----------------------------
Resolution: Fixed
Hadoop Flags: Reviewed
Patch committed to trunk. Thanks Aniket for review!
> Seperate validation rules from optimizer
> ----------------------------------------
>
> Key: PIG-3545
> URL: https://issues.apache.org/jira/browse/PIG-3545
> Project: Pig
> Issue Type: Bug
> Components: impl
> Reporter: Daniel Dai
> Assignee: Daniel Dai
> Fix For: 0.13.0
>
> Attachments: PIG-3545-1.patch, PIG-3545-2.patch, PIG-3545-3.patch
>
>
> A continuation of PIG-3492. We realize separate validation rules (such as
> DuplicateForEachColumnRewriteVisitor, ImplicitSplitInsertVisitor) from
> optimizer would make code clear. The reason is:
> 1. validation rule only need to run once
> 2. In contrast to optimization rule, validation rule works on an inconsistent
> plan, and should be careful about precondition. Also some global operation
> such as resetSchema is not possible on inconsistent plan
> 3. Some operations should work with unoptimized but validated plan, such as
> describe
> Also want to address PIG-3508 in the cleanup. We should call
> LogicalPlan.optimize explicitly rather than rely on HExecutionEngine.compile
> to do the logical plan optimization.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
