----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21454/#review43193 -----------------------------------------------------------
Ship it! +1 (non-binding) modulo the nits below. trunk/shims/src/hadoop20/org/apache/pig/backend/hadoop/executionengine/shims/HadoopShims.java <https://reviews.apache.org/r/21454/#comment77266> nit: inconsistent whitespace, although it seems inconsistent most of the time in Pig trunk/shims/src/hadoop23/org/apache/pig/backend/hadoop/executionengine/shims/HadoopShims.java <https://reviews.apache.org/r/21454/#comment77268> presumably there might be more cases in the future. Please name more explicitly such as: downgradeTaskReports[Array] - Gera Shegalov On May 14, 2014, 6:45 p.m., Aniket Mokashi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/21454/ > ----------------------------------------------------------- > > (Updated May 14, 2014, 6:45 p.m.) > > > Review request for pig, Daniel Dai, Jonathan Coveney, and Julien Le Dem. > > > Bugs: PIG-3913 > https://issues.apache.org/jira/browse/PIG-3913 > > > Repository: pig > > > Description > ------- > > Fixes pig counters by using correct interfaces to poll job counters. > > > Diffs > ----- > > > trunk/shims/src/hadoop20/org/apache/pig/backend/hadoop/executionengine/shims/HadoopShims.java > 1591154 > trunk/shims/src/hadoop23/org/apache/hadoop/mapred/DowngradeHelper.java > PRE-CREATION > > trunk/shims/src/hadoop23/org/apache/pig/backend/hadoop/executionengine/shims/HadoopShims.java > 1591154 > trunk/src/org/apache/pig/backend/hadoop/executionengine/Launcher.java > 1591154 > > trunk/src/org/apache/pig/backend/hadoop/executionengine/mapReduceLayer/MapReduceLauncher.java > 1591154 > trunk/src/org/apache/pig/tools/pigstats/InputStats.java 1591154 > trunk/src/org/apache/pig/tools/pigstats/JobStats.java 1591154 > trunk/src/org/apache/pig/tools/pigstats/OutputStats.java 1591154 > trunk/src/org/apache/pig/tools/pigstats/PigStats.java 1591154 > trunk/src/org/apache/pig/tools/pigstats/mapreduce/MRJobStats.java 1591154 > trunk/src/org/apache/pig/tools/pigstats/mapreduce/MRPigStatsUtil.java > 1591154 > trunk/src/org/apache/pig/tools/pigstats/mapreduce/SimplePigStats.java > 1591154 > > Diff: https://reviews.apache.org/r/21454/diff/ > > > Testing > ------- > > > Thanks, > > Aniket Mokashi > >
