[
https://issues.apache.org/jira/browse/PIG-4047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14075000#comment-14075000
]
Daniel Dai edited comment on PIG-4047 at 7/25/14 10:18 PM:
-----------------------------------------------------------
Addressing [~rohini]'s review comments:
* pig pom file
This should be a separate issue. Even without this change, we need to fix it.
Let me create a ticket
* Keep the pig-withouthadoop.jar
Put it in legacy directory in the new patch
* What other jars are produced in the base directory apart from pig.jar?
Fixed
was (Author: daijy):
Addressing [~rohini]'s review comments:
* pig pom file
This should be a separate issue. Even without this change, we need to fix it.
Let me create a ticket
* Keep the pig-withouthadoop.jar
Put it in legacy directory in the new patch
* What other jars are produced in the base directory apart from pig.jar?
Only pig-core.jar is in base dir, all others are in lib
> Break up pig withouthadoop and fat jar
> --------------------------------------
>
> Key: PIG-4047
> URL: https://issues.apache.org/jira/browse/PIG-4047
> Project: Pig
> Issue Type: Improvement
> Components: build
> Affects Versions: site
> Reporter: fang fang chen
> Assignee: fang fang chen
> Labels: build
> Fix For: 0.14.0
>
> Attachments: PIG-4047-1.patch, PIG-4047-2.patch, PIG-4047-3.patch,
> PIG-4047.patch
>
>
> pig-withouthadoop jar is packaging pig core and pig core dependencies. But
> this jar should be removed due to following items:
> 1. the name is confusing. User did not know what the jar is used for at a
> glance.
> 2. it is not absolutely clear for user what the core dependencies are.
> 3. it is hard to maintain dependencies, like dependencies version update.
> Maybe user want to try different version avro without repackaging.
> It is better to not use pig-withouthadoop jar, instead:
> 1. devided without hadoop jar into pig core and pig core dependencies.
> 2. save jars in 1# in lib directory
> 3. in pig script, always add all the jars in lib directory into classpath and
> add pig core jar into classpath.
> I used pig in this way since version 0.8.1 via launching pig grunt. No issue
> found yet.
> Current branch-0.13 is packaging following jars into pig-withouhadoop jar:
> <include name="antlr-runtime-${antlr.version}.jar"/>
> <include name="ST4-${stringtemplate.version}.jar"/>
> <include name="jline-${jline.version}.jar"/>
> <include name="jackson-mapper-asl-${jackson.version}.jar"/>
> <include name="jackson-core-asl-${jackson.version}.jar"/>
> <include name="joda-time-${joda-time.version}.jar"/>
> <include name="guava-${guava.version}.jar"/>
> <include name="automaton-${automaton.version}.jar"/>
> <include name="jansi-${jansi.version}.jar"/>
> <include name="avro-${avro.version}.jar"/>
> <include name="avro-mapred-${avro.version}.jar"/>
> <include name="trevni-core-${avro.version}.jar"/>
> <include name="trevni-avro-${avro.version}.jar"/>
> <include name="snappy-java-${snappy. version}.jar"/>
> We could save upper jars and pig-core jar into lib directory.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
