----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24789/#review51603 -----------------------------------------------------------
Ship it! Ship It! - Thejas Nair On Aug. 26, 2014, 10:35 p.m., Daniel Dai wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/24789/ > ----------------------------------------------------------- > > (Updated Aug. 26, 2014, 10:35 p.m.) > > > Review request for pig. > > > Repository: pig > > > Description > ------- > > See PIG-4128 > > > Diffs > ----- > > trunk/src/org/apache/pig/EvalFunc.java 1618727 > trunk/src/org/apache/pig/Main.java 1618727 > trunk/src/org/apache/pig/builtin/ABS.java 1618727 > trunk/src/org/apache/pig/builtin/ARITY.java 1618727 > trunk/src/org/apache/pig/builtin/AddDuration.java 1618727 > trunk/src/org/apache/pig/builtin/Assert.java 1618727 > trunk/src/org/apache/pig/builtin/BagSize.java 1618727 > trunk/src/org/apache/pig/builtin/BagToString.java 1618727 > trunk/src/org/apache/pig/builtin/BagToTuple.java 1618727 > trunk/src/org/apache/pig/builtin/Base.java 1618727 > trunk/src/org/apache/pig/builtin/BigDecimalAbs.java 1618727 > trunk/src/org/apache/pig/builtin/BigIntegerAbs.java 1618727 > trunk/src/org/apache/pig/builtin/CONCAT.java 1618727 > trunk/src/org/apache/pig/builtin/ConstantSize.java 1618727 > trunk/src/org/apache/pig/builtin/CubeDimensions.java 1618727 > trunk/src/org/apache/pig/builtin/CurrentTime.java 1618727 > trunk/src/org/apache/pig/builtin/DIFF.java 1618727 > trunk/src/org/apache/pig/builtin/DaysBetween.java 1618727 > trunk/src/org/apache/pig/builtin/DoubleRound.java 1618727 > trunk/src/org/apache/pig/builtin/DoubleRoundTo.java 1618727 > trunk/src/org/apache/pig/builtin/ENDSWITH.java 1618727 > trunk/src/org/apache/pig/builtin/EqualsIgnoreCase.java 1618727 > trunk/src/org/apache/pig/builtin/FloatAbs.java 1618727 > trunk/src/org/apache/pig/builtin/FloatRound.java 1618727 > trunk/src/org/apache/pig/builtin/FloatRoundTo.java 1618727 > trunk/src/org/apache/pig/builtin/GetDay.java 1618727 > trunk/src/org/apache/pig/builtin/GetHour.java 1618727 > trunk/src/org/apache/pig/builtin/GetMilliSecond.java 1618727 > trunk/src/org/apache/pig/builtin/GetMinute.java 1618727 > trunk/src/org/apache/pig/builtin/GetMonth.java 1618727 > trunk/src/org/apache/pig/builtin/GetSecond.java 1618727 > trunk/src/org/apache/pig/builtin/GetWeek.java 1618727 > trunk/src/org/apache/pig/builtin/GetWeekYear.java 1618727 > trunk/src/org/apache/pig/builtin/GetYear.java 1618727 > trunk/src/org/apache/pig/builtin/HoursBetween.java 1618727 > trunk/src/org/apache/pig/builtin/INDEXOF.java 1618727 > trunk/src/org/apache/pig/builtin/INVERSEMAP.java 1618727 > trunk/src/org/apache/pig/builtin/IntAbs.java 1618727 > trunk/src/org/apache/pig/builtin/IsEmpty.java 1618727 > trunk/src/org/apache/pig/builtin/KEYSET.java 1618727 > trunk/src/org/apache/pig/builtin/LAST_INDEX_OF.java 1618727 > trunk/src/org/apache/pig/builtin/LCFIRST.java 1618727 > trunk/src/org/apache/pig/builtin/LOWER.java 1618727 > trunk/src/org/apache/pig/builtin/LTRIM.java 1618727 > trunk/src/org/apache/pig/builtin/LongAbs.java 1618727 > trunk/src/org/apache/pig/builtin/MapSize.java 1618727 > trunk/src/org/apache/pig/builtin/MilliSecondsBetween.java 1618727 > trunk/src/org/apache/pig/builtin/MinutesBetween.java 1618727 > trunk/src/org/apache/pig/builtin/MonthsBetween.java 1618727 > trunk/src/org/apache/pig/builtin/PluckTuple.java 1618727 > trunk/src/org/apache/pig/builtin/REGEX_EXTRACT.java 1618727 > trunk/src/org/apache/pig/builtin/REGEX_EXTRACT_ALL.java 1618727 > trunk/src/org/apache/pig/builtin/REPLACE.java 1618727 > trunk/src/org/apache/pig/builtin/ROUND.java 1618727 > trunk/src/org/apache/pig/builtin/ROUND_TO.java 1618727 > trunk/src/org/apache/pig/builtin/RTRIM.java 1618727 > trunk/src/org/apache/pig/builtin/RollupDimensions.java 1618727 > trunk/src/org/apache/pig/builtin/SIZE.java 1618727 > trunk/src/org/apache/pig/builtin/SPRINTF.java 1618727 > trunk/src/org/apache/pig/builtin/STARTSWITH.java 1618727 > trunk/src/org/apache/pig/builtin/STRSPLIT.java 1618727 > trunk/src/org/apache/pig/builtin/SUBSTRING.java 1618727 > trunk/src/org/apache/pig/builtin/SUBTRACT.java 1618727 > trunk/src/org/apache/pig/builtin/SecondsBetween.java 1618727 > trunk/src/org/apache/pig/builtin/StringConcat.java 1618727 > trunk/src/org/apache/pig/builtin/StringSize.java 1618727 > trunk/src/org/apache/pig/builtin/SubtractDuration.java 1618727 > trunk/src/org/apache/pig/builtin/TOBAG.java 1618727 > trunk/src/org/apache/pig/builtin/TOKENIZE.java 1618727 > trunk/src/org/apache/pig/builtin/TOMAP.java 1618727 > trunk/src/org/apache/pig/builtin/TOTUPLE.java 1618727 > trunk/src/org/apache/pig/builtin/TRIM.java 1618727 > trunk/src/org/apache/pig/builtin/ToDate.java 1618727 > trunk/src/org/apache/pig/builtin/ToDate2ARGS.java 1618727 > trunk/src/org/apache/pig/builtin/ToDate3ARGS.java 1618727 > trunk/src/org/apache/pig/builtin/ToDateISO.java 1618727 > trunk/src/org/apache/pig/builtin/ToMilliSeconds.java 1618727 > trunk/src/org/apache/pig/builtin/ToString.java 1618727 > trunk/src/org/apache/pig/builtin/ToUnixTime.java 1618727 > trunk/src/org/apache/pig/builtin/TupleSize.java 1618727 > trunk/src/org/apache/pig/builtin/UCFIRST.java 1618727 > trunk/src/org/apache/pig/builtin/UPPER.java 1618727 > trunk/src/org/apache/pig/builtin/VALUELIST.java 1618727 > trunk/src/org/apache/pig/builtin/VALUESET.java 1618727 > trunk/src/org/apache/pig/builtin/WeeksBetween.java 1618727 > trunk/src/org/apache/pig/builtin/YearsBetween.java 1618727 > trunk/src/org/apache/pig/newplan/BaseOperatorPlan.java 1618727 > trunk/src/org/apache/pig/newplan/logical/expression/ConstantExpression.java > 1618727 > trunk/src/org/apache/pig/newplan/logical/expression/UserFuncExpression.java > 1618727 > > trunk/src/org/apache/pig/newplan/logical/optimizer/LogicalPlanOptimizer.java > 1618727 > trunk/src/org/apache/pig/newplan/logical/relational/LogicalPlan.java > 1618727 > trunk/src/org/apache/pig/newplan/logical/rules/ConstExpEvaluator.java > 1618727 > trunk/src/org/apache/pig/newplan/logical/rules/ConstantCalculator.java > PRE-CREATION > trunk/src/org/apache/pig/newplan/logical/rules/DNFExpression.java 1618727 > trunk/src/org/apache/pig/newplan/logical/rules/DNFPlan.java 1618727 > trunk/src/org/apache/pig/newplan/logical/rules/DNFPlanGenerator.java > 1618727 > > trunk/src/org/apache/pig/newplan/logical/rules/FilterConstantCalculator.java > PRE-CREATION > > trunk/src/org/apache/pig/newplan/logical/rules/ForEachConstantCalculator.java > PRE-CREATION > trunk/src/org/apache/pig/newplan/logical/rules/LogicalExpressionProxy.java > 1618727 > > trunk/src/org/apache/pig/newplan/logical/rules/LogicalExpressionSimplifier.java > 1618727 > trunk/src/org/apache/pig/newplan/logical/rules/NotConversionVisitor.java > 1618727 > trunk/test/org/apache/pig/test/TestConstantCalculator.java PRE-CREATION > trunk/test/org/apache/pig/test/TestFilterSimplification.java 1618727 > > Diff: https://reviews.apache.org/r/24789/diff/ > > > Testing > ------- > > All unit tests and e2e tests pass. > > > Thanks, > > Daniel Dai > >
