[
https://issues.apache.org/jira/browse/PIG-4235?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14171976#comment-14171976
]
Rohini Palaniswamy commented on PIG-4235:
-----------------------------------------
Few comments:
- Can remove the line <property name="windows" value="false"/>
- You can either use line or value with jvmarg
(http://ant.apache.org/manual/using.html#arg). So the new jvmarg value will be
overriding the existing jvmarg line one. For which unit test failure do we need
to add ${hadoop.root}\bin to library path?
- Do we need both Util.generateURI and Util.encodeEscape. Can we inline or
call Util.encodeEscape in Util.generateURI ?
- TestUnion.java - Can we also inline or call Util.encodeEscape in
Util.createInputFile. This would help avoid having to fix new tests often for
Windows and can also remove Util.encodeEscape from existing tests.
> Fix unit test failures on Windows
> ---------------------------------
>
> Key: PIG-4235
> URL: https://issues.apache.org/jira/browse/PIG-4235
> Project: Pig
> Issue Type: Bug
> Components: impl
> Reporter: Daniel Dai
> Assignee: Daniel Dai
> Fix For: 0.14.0
>
> Attachments: PIG-4235-1.patch
>
>
> Bunch of unit tests fail on trunk and 0.14 branch, we need to fix them.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
