[ 
https://issues.apache.org/jira/browse/PIG-4267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14197381#comment-14197381
 ] 

Brian Johnson commented on PIG-4267:
------------------------------------

I can tell you the only impact I saw and we have a lot of timezone dependent 
code: the "z" parameter in the date format will not always return the offset. 
If you pass in an offset for the timezone it will return an offset, but if you 
pass in something like America/New_York it will return EDT. That's not a pig 
issue, that's a joda issue and I think it's way more important to actually 
handle dates correctly than be backwards compatible with a format output.

As far as test cases go, I can't. The issue is that it depends on whether it's 
EDT or EST when you run the test. I could pick a date based on whether it was 
currently EDT or EST, but those dates have changed before and could change 
again which would break the test. There's also always an edge case if you run 
the test during the switch over.

> ToDate has incorrect timezone offsets
> -------------------------------------
>
>                 Key: PIG-4267
>                 URL: https://issues.apache.org/jira/browse/PIG-4267
>             Project: Pig
>          Issue Type: Bug
>    Affects Versions: 0.12.0, 0.13.1
>         Environment: java version 1.7.0_72
>            Reporter: Brian Johnson
>            Assignee: Brian Johnson
>         Attachments: patch
>
>
> If you set the timezone to 'America/New_York'
> Pig will return "2012-03-30 -05:00" for ToDate(1333166400000) instead of the 
> correct "2012-03-31 -04:00"



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to