[ 
https://issues.apache.org/jira/browse/PIG-3615?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14212752#comment-14212752
 ] 

Eyal Allweil commented on PIG-3615:
-----------------------------------

Daniel, you committed all of the older patch, the one that might cause backward 
compatibility problems. Can you switch it to the newer patch with changes to 
JsonLoader, but not JsonStorage?

We can of course go with the original patch, too, but then (at the very least) 
an appropriate warning should be put in the release notes about the change in 
big decimal write formats.

> Update the way that JsonLoader/JsonStorage deal with BigDecimal
> ---------------------------------------------------------------
>
>                 Key: PIG-3615
>                 URL: https://issues.apache.org/jira/browse/PIG-3615
>             Project: Pig
>          Issue Type: Improvement
>    Affects Versions: 0.12.0
>            Reporter: Erik Selin
>            Assignee: Erik Selin
>            Priority: Minor
>             Fix For: 0.15.0
>
>         Attachments: PIG-3615.patch, bugPig-3615.patch
>
>
> It's a common (and good) convention to quote fixed point numbers when storing 
> them as json. The reason being that majority of json libraries will 
> implicitly load any number value as a floating point number and if you care 
> about data integrity this will make you very sad.
> This update makes JsonLoader able to load BigDecimal values from quoted 
> values (the old jackson library that we're using doesn't support this through 
> the current approach) as well as making JsonStorage store BigDecimal values 
> as quoted strings.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to